[GitHub] [commons-crypto] geoffreyblake commented on a change in pull request #103: Standardize the release build process with Docker.

[GitBox <gi...@apache.org>]

geoffreyblake commented on a change in pull request #103:
URL: https://github.com/apache/commons-crypto/pull/103#discussion_r465202229



##########
File path: Dockerfile
##########
@@ -0,0 +1,35 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# This file builds the Linux-x86_64, Linux-arm, Linux-armfh. Linux aarch64 and Win64 jnilibs.  It copies the contents of
+# the build host's project directory (commons-crypto) into the docker image and cross compiles the remaining builds. If 
+# you run this script from a Mac after a successful build, the build in the resuing Docker image will include the Mac 
+# build.
+
+FROM ubuntu:18.04

Review comment:
       For building binaries to be used in a release, this should be ubuntu:14.04 or even centos:7 to retain as much compatibility as possible.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org