[jira] [Commented] (FLINK-4452) TaskManager network buffer gauges

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-4452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15433407#comment-15433407 ] 

ASF GitHub Bot commented on FLINK-4452:
---------------------------------------

GitHub user greghogan opened a pull request:

    https://github.com/apache/flink/pull/2408

    [FLINK-4452] TaskManager network buffer gauges

    Adds gauges for the number of total and available TaskManager network memory segments.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/greghogan/flink 4452_taskmanager_network_buffer_gauges

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2408.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2408
    
----
commit 1f8e7c93949d8b63747628ea1c31ccf46a524292
Author: Greg Hogan <co...@greghogan.com>
Date:   2016-08-23T14:46:48Z

    [FLINK-4452] TaskManager network buffer gauges
    
    Adds gauges for the number of total and available TaskManager network
    memory segments.

----


> TaskManager network buffer gauges
> ---------------------------------
>
>                 Key: FLINK-4452
>                 URL: https://issues.apache.org/jira/browse/FLINK-4452
>             Project: Flink
>          Issue Type: New Feature
>          Components: Metrics
>    Affects Versions: 1.2.0
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>            Priority: Minor
>
> Add gauges for {{network.getNetworkBufferPool.getTotalNumberOfMemorySegments}} and {{network.getNetworkBufferPool.getNumberOfAvailableMemorySegments}}.
> Providing insight into the number and proportion of used network buffers is vital and enlightening. Jobs terminate when buffers are not available, but also the rule-of-thumb for "Configuring the Network Buffers" from the documentation is way off. For example, running a sort on a single TaskManager with 8 slots I am using 16,000+ buffers which is much greater than 8*8*4 = 256.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)