You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@uima.apache.org by "Jerry Cwiklik (JIRA)" <ui...@incubator.apache.org> on 2008/09/23 19:38:44 UTC

[jira] Created: (UIMA-1189) Remove excessive synchronization from Uima As

Remove excessive synchronization from Uima As
---------------------------------------------

                 Key: UIMA-1189
                 URL: https://issues.apache.org/jira/browse/UIMA-1189
             Project: UIMA
          Issue Type: Improvement
          Components: Async Scaleout
            Reporter: Jerry Cwiklik


There are few places in the Uima AS code where synchronization is used for no reason. This may lead to locking code and potentially slowing down the processing.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (UIMA-1189) Remove excessive synchronization from Uima As

Posted by "Marshall Schor (JIRA)" <ui...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/UIMA-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marshall Schor updated UIMA-1189:
---------------------------------

    Fix Version/s: 2.3AS

> Remove excessive synchronization from Uima As
> ---------------------------------------------
>
>                 Key: UIMA-1189
>                 URL: https://issues.apache.org/jira/browse/UIMA-1189
>             Project: UIMA
>          Issue Type: Improvement
>          Components: Async Scaleout
>            Reporter: Jerry Cwiklik
>             Fix For: 2.3AS
>
>         Attachments: uimaj-as-activemq-UIMA-1189-patch-v2.txt, uimaj-as-activemq-UIMA-1189-patch.txt, uimaj-as-core-UIMA-1189-patch-v2.txt, uimaj-as-core-UIMA-1189-patch.txt
>
>
> There are few places in the Uima AS code where synchronization is used for no reason. This may lead to locking code and potentially slowing down the processing.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (UIMA-1189) Remove excessive synchronization from Uima As

Posted by "Jerry Cwiklik (JIRA)" <ui...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/UIMA-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jerry Cwiklik reopened UIMA-1189:
---------------------------------

      Assignee: Jerry Cwiklik

Findbugs reports excessive synchronization in the UIMA AS Aggregate code while trying to guard FlowController's flow map. This map is of ConcurrentHashMap type which has its own synchronization. There is also an attempt to synchronize on the CountDown latch. Remove  synchronization and instead depend on concurrency access provided by java data structures used.

> Remove excessive synchronization from Uima As
> ---------------------------------------------
>
>                 Key: UIMA-1189
>                 URL: https://issues.apache.org/jira/browse/UIMA-1189
>             Project: UIMA
>          Issue Type: Improvement
>          Components: Async Scaleout
>            Reporter: Jerry Cwiklik
>            Assignee: Jerry Cwiklik
>             Fix For: 2.3AS
>
>         Attachments: uimaj-as-activemq-UIMA-1189-patch-v2.txt, uimaj-as-activemq-UIMA-1189-patch.txt, uimaj-as-core-UIMA-1189-patch-v2.txt, uimaj-as-core-UIMA-1189-patch.txt
>
>
> There are few places in the Uima AS code where synchronization is used for no reason. This may lead to locking code and potentially slowing down the processing.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (UIMA-1189) Remove excessive synchronization from Uima As

Posted by "Jerry Cwiklik (JIRA)" <ui...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/UIMA-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jerry Cwiklik closed UIMA-1189.
-------------------------------

    Resolution: Fixed

> Remove excessive synchronization from Uima As
> ---------------------------------------------
>
>                 Key: UIMA-1189
>                 URL: https://issues.apache.org/jira/browse/UIMA-1189
>             Project: UIMA
>          Issue Type: Improvement
>          Components: Async Scaleout
>            Reporter: Jerry Cwiklik
>         Attachments: uimaj-as-activemq-UIMA-1189-patch-v2.txt, uimaj-as-activemq-UIMA-1189-patch.txt, uimaj-as-core-UIMA-1189-patch-v2.txt, uimaj-as-core-UIMA-1189-patch.txt
>
>
> There are few places in the Uima AS code where synchronization is used for no reason. This may lead to locking code and potentially slowing down the processing.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (UIMA-1189) Remove excessive synchronization from Uima As

Posted by "Jerry Cwiklik (JIRA)" <ui...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/UIMA-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jerry Cwiklik updated UIMA-1189:
--------------------------------

    Attachment: uimaj-as-core-UIMA-1189-patch-v2.txt
                uimaj-as-activemq-UIMA-1189-patch-v2.txt

Fixed a hang in AggregateController

> Remove excessive synchronization from Uima As
> ---------------------------------------------
>
>                 Key: UIMA-1189
>                 URL: https://issues.apache.org/jira/browse/UIMA-1189
>             Project: UIMA
>          Issue Type: Improvement
>          Components: Async Scaleout
>            Reporter: Jerry Cwiklik
>         Attachments: uimaj-as-activemq-UIMA-1189-patch-v2.txt, uimaj-as-activemq-UIMA-1189-patch.txt, uimaj-as-core-UIMA-1189-patch-v2.txt, uimaj-as-core-UIMA-1189-patch.txt
>
>
> There are few places in the Uima AS code where synchronization is used for no reason. This may lead to locking code and potentially slowing down the processing.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (UIMA-1189) Remove excessive synchronization from Uima As

Posted by "Jerry Cwiklik (JIRA)" <ui...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/UIMA-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jerry Cwiklik reopened UIMA-1189:
---------------------------------


Findbugs reports synchronization on ConcurrentHashMap in the uima-as-activemq project. Remove unnecessary synchronization

> Remove excessive synchronization from Uima As
> ---------------------------------------------
>
>                 Key: UIMA-1189
>                 URL: https://issues.apache.org/jira/browse/UIMA-1189
>             Project: UIMA
>          Issue Type: Improvement
>          Components: Async Scaleout
>            Reporter: Jerry Cwiklik
>            Assignee: Jerry Cwiklik
>             Fix For: 2.3AS
>
>         Attachments: uimaj-as-activemq-UIMA-1189-patch-v2.txt, uimaj-as-activemq-UIMA-1189-patch.txt, uimaj-as-core-UIMA-1189-patch-v2.txt, uimaj-as-core-UIMA-1189-patch.txt
>
>
> There are few places in the Uima AS code where synchronization is used for no reason. This may lead to locking code and potentially slowing down the processing.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (UIMA-1189) Remove excessive synchronization from Uima As

Posted by "Jerry Cwiklik (JIRA)" <ui...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/UIMA-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jerry Cwiklik closed UIMA-1189.
-------------------------------

    Resolution: Fixed

Uima As test harness code was synchronizing AtomicBoolean to signal events. Findbugs flags this as excessive synchronization. Refactored the code to use a semaphore. Removed explicit synchronization.

> Remove excessive synchronization from Uima As
> ---------------------------------------------
>
>                 Key: UIMA-1189
>                 URL: https://issues.apache.org/jira/browse/UIMA-1189
>             Project: UIMA
>          Issue Type: Improvement
>          Components: Async Scaleout
>            Reporter: Jerry Cwiklik
>            Assignee: Jerry Cwiklik
>             Fix For: 2.3AS
>
>         Attachments: uimaj-as-activemq-UIMA-1189-patch-v2.txt, uimaj-as-activemq-UIMA-1189-patch.txt, uimaj-as-core-UIMA-1189-patch-v2.txt, uimaj-as-core-UIMA-1189-patch.txt
>
>
> There are few places in the Uima AS code where synchronization is used for no reason. This may lead to locking code and potentially slowing down the processing.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (UIMA-1189) Remove excessive synchronization from Uima As

Posted by "Jerry Cwiklik (JIRA)" <ui...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/UIMA-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jerry Cwiklik updated UIMA-1189:
--------------------------------

    Attachment: uimaj-as-core-UIMA-1189-patch.txt
                uimaj-as-activemq-UIMA-1189-patch.txt

Refactored code to reduce impact of synchronized code. In some places synchronized blocks were quite long locking threads for no reason. Removed synchronized blocks where synchronization is not needed. 

> Remove excessive synchronization from Uima As
> ---------------------------------------------
>
>                 Key: UIMA-1189
>                 URL: https://issues.apache.org/jira/browse/UIMA-1189
>             Project: UIMA
>          Issue Type: Improvement
>          Components: Async Scaleout
>            Reporter: Jerry Cwiklik
>         Attachments: uimaj-as-activemq-UIMA-1189-patch.txt, uimaj-as-core-UIMA-1189-patch.txt
>
>
> There are few places in the Uima AS code where synchronization is used for no reason. This may lead to locking code and potentially slowing down the processing.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (UIMA-1189) Remove excessive synchronization from Uima As

Posted by "Jerry Cwiklik (JIRA)" <ui...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/UIMA-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jerry Cwiklik closed UIMA-1189.
-------------------------------

    Resolution: Fixed

Removed excessive synchronization from the UIMA AS aggregate

> Remove excessive synchronization from Uima As
> ---------------------------------------------
>
>                 Key: UIMA-1189
>                 URL: https://issues.apache.org/jira/browse/UIMA-1189
>             Project: UIMA
>          Issue Type: Improvement
>          Components: Async Scaleout
>            Reporter: Jerry Cwiklik
>            Assignee: Jerry Cwiklik
>             Fix For: 2.3AS
>
>         Attachments: uimaj-as-activemq-UIMA-1189-patch-v2.txt, uimaj-as-activemq-UIMA-1189-patch.txt, uimaj-as-core-UIMA-1189-patch-v2.txt, uimaj-as-core-UIMA-1189-patch.txt
>
>
> There are few places in the Uima AS code where synchronization is used for no reason. This may lead to locking code and potentially slowing down the processing.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.