You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2016/02/23 01:54:40 UTC
Review Request 43860: Used uri::Fetcher to pull docker images in
docker registry puller.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43860/
-----------------------------------------------------------
Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen.
Bugs: MESOS-4261 and MESOS-4499
https://issues.apache.org/jira/browse/MESOS-4261
https://issues.apache.org/jira/browse/MESOS-4499
Repository: mesos
Description
-------
This is the second step of cleaning/simplying the docker registry puller code.
The new code uses the uri::Fetcher to download docker manifest and blobs (instead of writting our own http logic which requires enabling of SSL for Mesos).
Diffs
-----
src/slave/containerizer/mesos/provisioner/docker/puller.hpp 5b2d72c22fcbcc379b4901607cf3eb682de66206
src/slave/containerizer/mesos/provisioner/docker/puller.cpp a239b97557ad20353c67050dbc89ef16da898330
src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp bccbac11113357cf942446604e6cf5d16c3d594b
src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 3fcf1471a035e35a2cac22442655ad65a84a9793
src/slave/containerizer/mesos/provisioner/docker/store.cpp 2f1d3e002140f34c646aab445a419c9c3d712f99
src/slave/flags.hpp 54c1a69d8777f417cdd8f73ce638447d9951ab61
src/slave/flags.cpp 855812e9f7cb4b96d4297f4bd5ac5de7f1d3c39a
src/slave/http.cpp a18085ea020d0d6c39f23213e11af75a02eedb7e
src/tests/containerizer/provisioner_docker_tests.cpp 4db6793a21abbb7ea4de0d0fca0431237d38d013
Diff: https://reviews.apache.org/r/43860/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 43860: Used uri::Fetcher to pull docker images in
docker registry puller.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43860/#review120314
-----------------------------------------------------------
Bad patch!
Reviews applied: [43860, 43801]
Failed command: ./support/apply-review.sh -n -r 43860
Error:
2016-02-23 14:52:20 URL:https://reviews.apache.org/r/43860/diff/raw/ [52668/52668] -> "43860.patch" [1]
error: patch failed: src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp:38
error: src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp: patch does not apply
Full log: https://builds.apache.org/job/mesos-reviewbot/11605/console
- Mesos ReviewBot
On Feb. 23, 2016, 12:54 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43860/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2016, 12:54 a.m.)
>
>
> Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen.
>
>
> Bugs: MESOS-4261 and MESOS-4499
> https://issues.apache.org/jira/browse/MESOS-4261
> https://issues.apache.org/jira/browse/MESOS-4499
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is the second step of cleaning/simplying the docker registry puller code.
>
> The new code uses the uri::Fetcher to download docker manifest and blobs (instead of writting our own http logic which requires enabling of SSL for Mesos).
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/puller.hpp 5b2d72c22fcbcc379b4901607cf3eb682de66206
> src/slave/containerizer/mesos/provisioner/docker/puller.cpp a239b97557ad20353c67050dbc89ef16da898330
> src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp bccbac11113357cf942446604e6cf5d16c3d594b
> src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 3fcf1471a035e35a2cac22442655ad65a84a9793
> src/slave/containerizer/mesos/provisioner/docker/store.cpp 2f1d3e002140f34c646aab445a419c9c3d712f99
> src/slave/flags.hpp 54c1a69d8777f417cdd8f73ce638447d9951ab61
> src/slave/flags.cpp 855812e9f7cb4b96d4297f4bd5ac5de7f1d3c39a
> src/slave/http.cpp a18085ea020d0d6c39f23213e11af75a02eedb7e
> src/tests/containerizer/provisioner_docker_tests.cpp 4db6793a21abbb7ea4de0d0fca0431237d38d013
>
> Diff: https://reviews.apache.org/r/43860/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 43860: Used uri::Fetcher to pull docker images in
docker registry puller.
Posted by Jie Yu <yu...@gmail.com>.
> On Feb. 23, 2016, 7:45 a.m., Guangya Liu wrote:
> > Some doc may also need to be changed by removing the ssl related configurations, such as
> >
> > https://github.com/apache/mesos/blob/master/docs/endpoints/slave/state.json.md
> > https://github.com/apache/mesos/blob/master/docs/endpoints/slave/state.md
> > https://github.com/apache/mesos/blob/master/docs/configuration.md
Done.
> On Feb. 23, 2016, 7:45 a.m., Guangya Liu wrote:
> > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp, line 180
> > <https://reviews.apache.org/r/43860/diff/1/?file=1264880#file1264880line180>
> >
> > what about highlighting the words with `` but not ''?
Have we agreed on that? I use '' all the time.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43860/#review120273
-----------------------------------------------------------
On Feb. 23, 2016, 8:12 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43860/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2016, 8:12 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen.
>
>
> Bugs: MESOS-4261 and MESOS-4499
> https://issues.apache.org/jira/browse/MESOS-4261
> https://issues.apache.org/jira/browse/MESOS-4499
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is the second step of cleaning/simplying the docker registry puller code.
>
> Used uri::Fetcher to pull docker images in docker registry puller.
>
> The new code uses the uri::Fetcher to download docker manifest and blobs (instead of writting our own http logic which requires enabling of SSL for Mesos).
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/puller.hpp 5b2d72c22fcbcc379b4901607cf3eb682de66206
> src/slave/containerizer/mesos/provisioner/docker/puller.cpp a239b97557ad20353c67050dbc89ef16da898330
> src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp bccbac11113357cf942446604e6cf5d16c3d594b
> src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 3fcf1471a035e35a2cac22442655ad65a84a9793
> src/slave/containerizer/mesos/provisioner/docker/store.cpp 2f1d3e002140f34c646aab445a419c9c3d712f99
> src/slave/flags.hpp 54c1a69d8777f417cdd8f73ce638447d9951ab61
> src/slave/flags.cpp 855812e9f7cb4b96d4297f4bd5ac5de7f1d3c39a
> src/slave/http.cpp a18085ea020d0d6c39f23213e11af75a02eedb7e
> src/tests/containerizer/provisioner_docker_tests.cpp 4db6793a21abbb7ea4de0d0fca0431237d38d013
>
> Diff: https://reviews.apache.org/r/43860/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 43860: Used uri::Fetcher to pull docker images in
docker registry puller.
Posted by Jie Yu <yu...@gmail.com>.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43860/#review120273
-----------------------------------------------------------
On Feb. 23, 2016, 8:12 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43860/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2016, 8:12 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen.
>
>
> Bugs: MESOS-4261 and MESOS-4499
> https://issues.apache.org/jira/browse/MESOS-4261
> https://issues.apache.org/jira/browse/MESOS-4499
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is the second step of cleaning/simplying the docker registry puller code.
>
> Used uri::Fetcher to pull docker images in docker registry puller.
>
> The new code uses the uri::Fetcher to download docker manifest and blobs (instead of writting our own http logic which requires enabling of SSL for Mesos).
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/puller.hpp 5b2d72c22fcbcc379b4901607cf3eb682de66206
> src/slave/containerizer/mesos/provisioner/docker/puller.cpp a239b97557ad20353c67050dbc89ef16da898330
> src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp bccbac11113357cf942446604e6cf5d16c3d594b
> src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 3fcf1471a035e35a2cac22442655ad65a84a9793
> src/slave/containerizer/mesos/provisioner/docker/store.cpp 2f1d3e002140f34c646aab445a419c9c3d712f99
> src/slave/flags.hpp 54c1a69d8777f417cdd8f73ce638447d9951ab61
> src/slave/flags.cpp 855812e9f7cb4b96d4297f4bd5ac5de7f1d3c39a
> src/slave/http.cpp a18085ea020d0d6c39f23213e11af75a02eedb7e
> src/tests/containerizer/provisioner_docker_tests.cpp 4db6793a21abbb7ea4de0d0fca0431237d38d013
>
> Diff: https://reviews.apache.org/r/43860/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 43860: Used uri::Fetcher to pull docker images in
docker registry puller.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43860/#review120273
-----------------------------------------------------------
Some doc may also need to be changed by removing the ssl related configurations, such as
https://github.com/apache/mesos/blob/master/docs/endpoints/slave/state.json.md
https://github.com/apache/mesos/blob/master/docs/endpoints/slave/state.md
https://github.com/apache/mesos/blob/master/docs/configuration.md
src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp (line 158)
<https://reviews.apache.org/r/43860/#comment181708>
what about highlighting the words with `` but not ''?
src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp (lines 236 - 237)
<https://reviews.apache.org/r/43860/#comment181709>
What about keep this log but update it to "Fetching layer "
src/tests/containerizer/provisioner_docker_tests.cpp (line 325)
<https://reviews.apache.org/r/43860/#comment181707>
most of the test with docker images are now using `alpine`
- Guangya Liu
On 二月 23, 2016, 12:54 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43860/
> -----------------------------------------------------------
>
> (Updated 二月 23, 2016, 12:54 a.m.)
>
>
> Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen.
>
>
> Bugs: MESOS-4261 and MESOS-4499
> https://issues.apache.org/jira/browse/MESOS-4261
> https://issues.apache.org/jira/browse/MESOS-4499
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is the second step of cleaning/simplying the docker registry puller code.
>
> The new code uses the uri::Fetcher to download docker manifest and blobs (instead of writting our own http logic which requires enabling of SSL for Mesos).
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/puller.hpp 5b2d72c22fcbcc379b4901607cf3eb682de66206
> src/slave/containerizer/mesos/provisioner/docker/puller.cpp a239b97557ad20353c67050dbc89ef16da898330
> src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp bccbac11113357cf942446604e6cf5d16c3d594b
> src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 3fcf1471a035e35a2cac22442655ad65a84a9793
> src/slave/containerizer/mesos/provisioner/docker/store.cpp 2f1d3e002140f34c646aab445a419c9c3d712f99
> src/slave/flags.hpp 54c1a69d8777f417cdd8f73ce638447d9951ab61
> src/slave/flags.cpp 855812e9f7cb4b96d4297f4bd5ac5de7f1d3c39a
> src/slave/http.cpp a18085ea020d0d6c39f23213e11af75a02eedb7e
> src/tests/containerizer/provisioner_docker_tests.cpp 4db6793a21abbb7ea4de0d0fca0431237d38d013
>
> Diff: https://reviews.apache.org/r/43860/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 43860: Used uri::Fetcher to pull docker images in
docker registry puller.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43860/#review120408
-----------------------------------------------------------
Ship it!
Tested with mesos-execute --docker_image=library/busybox.
- Gilbert Song
On Feb. 23, 2016, 12:12 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43860/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2016, 12:12 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen.
>
>
> Bugs: MESOS-4261 and MESOS-4499
> https://issues.apache.org/jira/browse/MESOS-4261
> https://issues.apache.org/jira/browse/MESOS-4499
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is the second step of cleaning/simplying the docker registry puller code.
>
> Used uri::Fetcher to pull docker images in docker registry puller.
>
> The new code uses the uri::Fetcher to download docker manifest and blobs (instead of writting our own http logic which requires enabling of SSL for Mesos).
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/puller.hpp 5b2d72c22fcbcc379b4901607cf3eb682de66206
> src/slave/containerizer/mesos/provisioner/docker/puller.cpp a239b97557ad20353c67050dbc89ef16da898330
> src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp bccbac11113357cf942446604e6cf5d16c3d594b
> src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 3fcf1471a035e35a2cac22442655ad65a84a9793
> src/slave/containerizer/mesos/provisioner/docker/store.cpp 2f1d3e002140f34c646aab445a419c9c3d712f99
> src/slave/flags.hpp 54c1a69d8777f417cdd8f73ce638447d9951ab61
> src/slave/flags.cpp 855812e9f7cb4b96d4297f4bd5ac5de7f1d3c39a
> src/slave/http.cpp a18085ea020d0d6c39f23213e11af75a02eedb7e
> src/tests/containerizer/provisioner_docker_tests.cpp 4db6793a21abbb7ea4de0d0fca0431237d38d013
>
> Diff: https://reviews.apache.org/r/43860/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 43860: Used uri::Fetcher to pull docker images in
docker registry puller.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43860/
-----------------------------------------------------------
(Updated Feb. 23, 2016, 8:12 p.m.)
Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen.
Bugs: MESOS-4261 and MESOS-4499
https://issues.apache.org/jira/browse/MESOS-4261
https://issues.apache.org/jira/browse/MESOS-4499
Repository: mesos
Description (updated)
-------
This is the second step of cleaning/simplying the docker registry puller code.
Used uri::Fetcher to pull docker images in docker registry puller.
The new code uses the uri::Fetcher to download docker manifest and blobs (instead of writting our own http logic which requires enabling of SSL for Mesos).
Diffs
-----
src/slave/containerizer/mesos/provisioner/docker/puller.hpp 5b2d72c22fcbcc379b4901607cf3eb682de66206
src/slave/containerizer/mesos/provisioner/docker/puller.cpp a239b97557ad20353c67050dbc89ef16da898330
src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp bccbac11113357cf942446604e6cf5d16c3d594b
src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 3fcf1471a035e35a2cac22442655ad65a84a9793
src/slave/containerizer/mesos/provisioner/docker/store.cpp 2f1d3e002140f34c646aab445a419c9c3d712f99
src/slave/flags.hpp 54c1a69d8777f417cdd8f73ce638447d9951ab61
src/slave/flags.cpp 855812e9f7cb4b96d4297f4bd5ac5de7f1d3c39a
src/slave/http.cpp a18085ea020d0d6c39f23213e11af75a02eedb7e
src/tests/containerizer/provisioner_docker_tests.cpp 4db6793a21abbb7ea4de0d0fca0431237d38d013
Diff: https://reviews.apache.org/r/43860/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 43860: Used uri::Fetcher to pull docker images in
docker registry puller.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43860/
-----------------------------------------------------------
(Updated Feb. 23, 2016, 8:11 p.m.)
Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen.
Changes
-------
Rebased.
Bugs: MESOS-4261 and MESOS-4499
https://issues.apache.org/jira/browse/MESOS-4261
https://issues.apache.org/jira/browse/MESOS-4499
Repository: mesos
Description (updated)
-------
Used uri::Fetcher to pull docker images in docker registry puller.
Diffs (updated)
-----
src/slave/containerizer/mesos/provisioner/docker/puller.hpp 5b2d72c22fcbcc379b4901607cf3eb682de66206
src/slave/containerizer/mesos/provisioner/docker/puller.cpp a239b97557ad20353c67050dbc89ef16da898330
src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp bccbac11113357cf942446604e6cf5d16c3d594b
src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 3fcf1471a035e35a2cac22442655ad65a84a9793
src/slave/containerizer/mesos/provisioner/docker/store.cpp 2f1d3e002140f34c646aab445a419c9c3d712f99
src/slave/flags.hpp 54c1a69d8777f417cdd8f73ce638447d9951ab61
src/slave/flags.cpp 855812e9f7cb4b96d4297f4bd5ac5de7f1d3c39a
src/slave/http.cpp a18085ea020d0d6c39f23213e11af75a02eedb7e
src/tests/containerizer/provisioner_docker_tests.cpp 4db6793a21abbb7ea4de0d0fca0431237d38d013
Diff: https://reviews.apache.org/r/43860/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 43860: Used uri::Fetcher to pull docker images in
docker registry puller.
Posted by Jie Yu <yu...@gmail.com>.
> On Feb. 23, 2016, 7:27 p.m., Gilbert Song wrote:
> > src/tests/containerizer/provisioner_docker_tests.cpp, line 1267
> > <https://reviews.apache.org/r/43860/diff/1/?file=1264885#file1264885line1267>
> >
> > Could we do `EXPECT_EQ(2u, imageInfo->layers.size())` ?
We don't know that for sure, right:)
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43860/#review120364
-----------------------------------------------------------
On Feb. 23, 2016, 8:12 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43860/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2016, 8:12 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen.
>
>
> Bugs: MESOS-4261 and MESOS-4499
> https://issues.apache.org/jira/browse/MESOS-4261
> https://issues.apache.org/jira/browse/MESOS-4499
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is the second step of cleaning/simplying the docker registry puller code.
>
> Used uri::Fetcher to pull docker images in docker registry puller.
>
> The new code uses the uri::Fetcher to download docker manifest and blobs (instead of writting our own http logic which requires enabling of SSL for Mesos).
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/puller.hpp 5b2d72c22fcbcc379b4901607cf3eb682de66206
> src/slave/containerizer/mesos/provisioner/docker/puller.cpp a239b97557ad20353c67050dbc89ef16da898330
> src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp bccbac11113357cf942446604e6cf5d16c3d594b
> src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 3fcf1471a035e35a2cac22442655ad65a84a9793
> src/slave/containerizer/mesos/provisioner/docker/store.cpp 2f1d3e002140f34c646aab445a419c9c3d712f99
> src/slave/flags.hpp 54c1a69d8777f417cdd8f73ce638447d9951ab61
> src/slave/flags.cpp 855812e9f7cb4b96d4297f4bd5ac5de7f1d3c39a
> src/slave/http.cpp a18085ea020d0d6c39f23213e11af75a02eedb7e
> src/tests/containerizer/provisioner_docker_tests.cpp 4db6793a21abbb7ea4de0d0fca0431237d38d013
>
> Diff: https://reviews.apache.org/r/43860/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 43860: Used uri::Fetcher to pull docker images in
docker registry puller.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43860/#review120364
-----------------------------------------------------------
The patch looks good to me. Could you rebase? I want to apply the patch and test with mesos-execute.
src/tests/containerizer/provisioner_docker_tests.cpp (line 330)
<https://reviews.apache.org/r/43860/#comment181799>
Could we do `EXPECT_EQ(2u, imageInfo->layers.size())` ?
- Gilbert Song
On Feb. 22, 2016, 4:54 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43860/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2016, 4:54 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen.
>
>
> Bugs: MESOS-4261 and MESOS-4499
> https://issues.apache.org/jira/browse/MESOS-4261
> https://issues.apache.org/jira/browse/MESOS-4499
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is the second step of cleaning/simplying the docker registry puller code.
>
> The new code uses the uri::Fetcher to download docker manifest and blobs (instead of writting our own http logic which requires enabling of SSL for Mesos).
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/puller.hpp 5b2d72c22fcbcc379b4901607cf3eb682de66206
> src/slave/containerizer/mesos/provisioner/docker/puller.cpp a239b97557ad20353c67050dbc89ef16da898330
> src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp bccbac11113357cf942446604e6cf5d16c3d594b
> src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 3fcf1471a035e35a2cac22442655ad65a84a9793
> src/slave/containerizer/mesos/provisioner/docker/store.cpp 2f1d3e002140f34c646aab445a419c9c3d712f99
> src/slave/flags.hpp 54c1a69d8777f417cdd8f73ce638447d9951ab61
> src/slave/flags.cpp 855812e9f7cb4b96d4297f4bd5ac5de7f1d3c39a
> src/slave/http.cpp a18085ea020d0d6c39f23213e11af75a02eedb7e
> src/tests/containerizer/provisioner_docker_tests.cpp 4db6793a21abbb7ea4de0d0fca0431237d38d013
>
> Diff: https://reviews.apache.org/r/43860/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 43860: Used uri::Fetcher to pull docker images in
docker registry puller.
Posted by Jie Yu <yu...@gmail.com>.
> On Feb. 23, 2016, 7:41 p.m., Jojy Varghese wrote:
> > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp, line 258
> > <https://reviews.apache.org/r/43860/diff/1/?file=1264880#file1264880line258>
> >
> > Not yours but do we need a CHECK here or a graceful failure.
I think that's an impossible case. So assertion here sounds fine to me.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43860/#review120367
-----------------------------------------------------------
On Feb. 23, 2016, 8:12 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43860/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2016, 8:12 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen.
>
>
> Bugs: MESOS-4261 and MESOS-4499
> https://issues.apache.org/jira/browse/MESOS-4261
> https://issues.apache.org/jira/browse/MESOS-4499
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is the second step of cleaning/simplying the docker registry puller code.
>
> Used uri::Fetcher to pull docker images in docker registry puller.
>
> The new code uses the uri::Fetcher to download docker manifest and blobs (instead of writting our own http logic which requires enabling of SSL for Mesos).
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/puller.hpp 5b2d72c22fcbcc379b4901607cf3eb682de66206
> src/slave/containerizer/mesos/provisioner/docker/puller.cpp a239b97557ad20353c67050dbc89ef16da898330
> src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp bccbac11113357cf942446604e6cf5d16c3d594b
> src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 3fcf1471a035e35a2cac22442655ad65a84a9793
> src/slave/containerizer/mesos/provisioner/docker/store.cpp 2f1d3e002140f34c646aab445a419c9c3d712f99
> src/slave/flags.hpp 54c1a69d8777f417cdd8f73ce638447d9951ab61
> src/slave/flags.cpp 855812e9f7cb4b96d4297f4bd5ac5de7f1d3c39a
> src/slave/http.cpp a18085ea020d0d6c39f23213e11af75a02eedb7e
> src/tests/containerizer/provisioner_docker_tests.cpp 4db6793a21abbb7ea4de0d0fca0431237d38d013
>
> Diff: https://reviews.apache.org/r/43860/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 43860: Used uri::Fetcher to pull docker images in
docker registry puller.
Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43860/#review120367
-----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp (line 214)
<https://reviews.apache.org/r/43860/#comment181802>
Not yours but do we need a CHECK here or a graceful failure.
src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp (line 256)
<https://reviews.apache.org/r/43860/#comment181803>
Does not apply for this patch, but might have to change the port type to posix type `in_port_t `
- Jojy Varghese
On Feb. 23, 2016, 12:54 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43860/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2016, 12:54 a.m.)
>
>
> Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen.
>
>
> Bugs: MESOS-4261 and MESOS-4499
> https://issues.apache.org/jira/browse/MESOS-4261
> https://issues.apache.org/jira/browse/MESOS-4499
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is the second step of cleaning/simplying the docker registry puller code.
>
> The new code uses the uri::Fetcher to download docker manifest and blobs (instead of writting our own http logic which requires enabling of SSL for Mesos).
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/puller.hpp 5b2d72c22fcbcc379b4901607cf3eb682de66206
> src/slave/containerizer/mesos/provisioner/docker/puller.cpp a239b97557ad20353c67050dbc89ef16da898330
> src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp bccbac11113357cf942446604e6cf5d16c3d594b
> src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 3fcf1471a035e35a2cac22442655ad65a84a9793
> src/slave/containerizer/mesos/provisioner/docker/store.cpp 2f1d3e002140f34c646aab445a419c9c3d712f99
> src/slave/flags.hpp 54c1a69d8777f417cdd8f73ce638447d9951ab61
> src/slave/flags.cpp 855812e9f7cb4b96d4297f4bd5ac5de7f1d3c39a
> src/slave/http.cpp a18085ea020d0d6c39f23213e11af75a02eedb7e
> src/tests/containerizer/provisioner_docker_tests.cpp 4db6793a21abbb7ea4de0d0fca0431237d38d013
>
> Diff: https://reviews.apache.org/r/43860/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>