You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Majid Kalkatechi (JIRA)" <ji...@apache.org> on 2007/03/28 09:06:32 UTC
[jira] Created: (OFBIZ-852) presenting languages and countries as
"English - United State" instead of "English (United States)" because of
right-to-left problems
presenting languages and countries as "English - United State" instead of "English (United States)" because of right-to-left problems
-------------------------------------------------------------------------------------------------------------------------------------
Key: OFBIZ-852
URL: https://issues.apache.org/jira/browse/OFBIZ-852
Project: OFBiz (The Open for Business Project)
Issue Type: Improvement
Components: framework
Reporter: Majid Kalkatechi
Priority: Trivial
In right-to-left languages(like Farsi,Arabic,...), language options will became like : ")English (United State ", this is because of parenthesis that is not became right-to-left properly. If we display the languages and their countries like "English - United State", instead of "English (United State )", this problem will be gone.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-852) presenting languages and countries as
"English - United State" instead of "English (United States)" because of
right-to-left problems
Posted by "Majid Kalkatechi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Majid Kalkatechi updated OFBIZ-852:
-----------------------------------
Attachment: header.patch
hi chris,
Thanks for your suggestions.
1. I attached one new file and I hope this will help much better.
2. parenthesis has different code when they are used in rtl languages and right-parenthesis code will become left-parenthesis code because '(' must be seen as ')' , in rtl languages. When we use .properties files its the job of translator to be aware of this, but as we can see, Locale.getDisplayName will return same string, even if the locale is rtl. To test what will happen, if the page is rtl, put dir="rtl" in the body tag or direction="rtl" in main.css, and you will see the side effect of changing the direction.
3. If the location of language select box is changed then I will change that place to became appropriate for this sort of languages.
> presenting languages and countries as "English - United State" instead of "English (United States)" because of right-to-left problems
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-852
> URL: https://issues.apache.org/jira/browse/OFBIZ-852
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Reporter: Majid Kalkatechi
> Priority: Trivial
> Attachments: header.ftl, header.patch
>
>
> In right-to-left languages(like Farsi,Arabic,...), language options will became like : ")English (United State ", this is because of parenthesis that is not became right-to-left properly. If we display the languages and their countries like "English - United State", instead of "English (United State )", this problem will be gone.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-852) presenting languages and countries as
"English - United State" instead of "English (United States)" because of
right-to-left problems
Posted by "Chris Howe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12484871 ]
Chris Howe commented on OFBIZ-852:
----------------------------------
Hi Majid,
A couple of things.
1) If you could create a patch file, it will be much easier to see the changes that you're requesting.
2) Why would "English (United States)" be affected by rtl language? Shouldn't locales be shown in the direction of the language of the locale? While it may currently be this way, I wouldn't expect to see Arabic or Farsi locales to read left to right in the dropdown when the set locale is English (United States)
3) There's been discussion about moving that from off of the header
> presenting languages and countries as "English - United State" instead of "English (United States)" because of right-to-left problems
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-852
> URL: https://issues.apache.org/jira/browse/OFBIZ-852
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Reporter: Majid Kalkatechi
> Priority: Trivial
> Attachments: header.ftl
>
>
> In right-to-left languages(like Farsi,Arabic,...), language options will became like : ")English (United State ", this is because of parenthesis that is not became right-to-left properly. If we display the languages and their countries like "English - United State", instead of "English (United State )", this problem will be gone.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-852) presenting languages and countries as
"English - United State" instead of "English (United States)" because of
right-to-left problems
Posted by "Chris Howe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12485021 ]
Chris Howe commented on OFBIZ-852:
----------------------------------
The problem is not only the select element. Check the order manager application. The filter type on the open order list uses parentheses that has the same problem
> presenting languages and countries as "English - United State" instead of "English (United States)" because of right-to-left problems
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-852
> URL: https://issues.apache.org/jira/browse/OFBIZ-852
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Reporter: Majid Kalkatechi
> Priority: Trivial
> Attachments: header.ftl, header.patch
>
>
> In right-to-left languages(like Farsi,Arabic,...), language options will became like : ")English (United State ", this is because of parenthesis that is not became right-to-left properly. If we display the languages and their countries like "English - United State", instead of "English (United State )", this problem will be gone.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-852) presenting languages and countries as
"English - United State" instead of "English (United States)" because of
right-to-left problems
Posted by "Majid Kalkatechi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12485074 ]
Majid Kalkatechi commented on OFBIZ-852:
----------------------------------------
This problem make sense when we use "Latin alphabet" in rtl direction, Arabic alphabet ,as I tested, didn't have any problem,even in 'order list' screen.
Now, I'm thinking how we can change direction automatically in page, my best idea is to put it in properties file, so it became part of internationalization system.
But as we can see, some elements of a page always have "Latin alphabet" (like language select box), this elements have to keep thier ltr direction, even in rtl contexts.
I know that this idea is so far from the topic of the issue and need more efforts around, so I will open an issue about this problem.
> presenting languages and countries as "English - United State" instead of "English (United States)" because of right-to-left problems
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-852
> URL: https://issues.apache.org/jira/browse/OFBIZ-852
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Reporter: Majid Kalkatechi
> Priority: Trivial
> Attachments: header.ftl, header.patch
>
>
> In right-to-left languages(like Farsi,Arabic,...), language options will became like : ")English (United State ", this is because of parenthesis that is not became right-to-left properly. If we display the languages and their countries like "English - United State", instead of "English (United State )", this problem will be gone.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-852) presenting languages and countries as
"English - United State" instead of "English (United States)" because of
right-to-left problems
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489168 ]
Adrian Crum commented on OFBIZ-852:
-----------------------------------
This issue can be closed. Problem fixed in revision 528925.
> presenting languages and countries as "English - United State" instead of "English (United States)" because of right-to-left problems
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-852
> URL: https://issues.apache.org/jira/browse/OFBIZ-852
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Reporter: Majid Kalkatechi
> Priority: Trivial
> Attachments: header.ftl, header.patch
>
>
> In right-to-left languages(like Farsi,Arabic,...), language options will became like : ")English (United State ", this is because of parenthesis that is not became right-to-left properly. If we display the languages and their countries like "English - United State", instead of "English (United State )", this problem will be gone.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-852) presenting languages and countries as
"English - United State" instead of "English (United States)" because of
right-to-left problems
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12485000 ]
Adrian Crum commented on OFBIZ-852:
-----------------------------------
Since the string is coming from java.util.Locale, I think we need to dig a little deeper to find out why it is coming out incorrectly.
Maybe the server's locale hasn't been set up properly, or there needs to be more research into how the class constructs the string.
If we end up having OFBiz performing a workaround, then it should be conditional. The workaround should be applied only in the case of languages where the problem reveals itself.
> presenting languages and countries as "English - United State" instead of "English (United States)" because of right-to-left problems
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-852
> URL: https://issues.apache.org/jira/browse/OFBIZ-852
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Reporter: Majid Kalkatechi
> Priority: Trivial
> Attachments: header.ftl, header.patch
>
>
> In right-to-left languages(like Farsi,Arabic,...), language options will became like : ")English (United State ", this is because of parenthesis that is not became right-to-left properly. If we display the languages and their countries like "English - United State", instead of "English (United State )", this problem will be gone.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-852) presenting languages and countries as
"English - United State" instead of "English (United States)" because of
right-to-left problems
Posted by "Majid Kalkatechi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Majid Kalkatechi updated OFBIZ-852:
-----------------------------------
Attachment: header.ftl
This file is improved version of header.ftl (in [OFBIZ_HOME/framework/common/webcommon/includes/header.ftl]) that the parenthesis of Locale.getDisplayName(); is removed and replaced with one '-'
> presenting languages and countries as "English - United State" instead of "English (United States)" because of right-to-left problems
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-852
> URL: https://issues.apache.org/jira/browse/OFBIZ-852
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Reporter: Majid Kalkatechi
> Priority: Trivial
> Attachments: header.ftl
>
>
> In right-to-left languages(like Farsi,Arabic,...), language options will became like : ")English (United State ", this is because of parenthesis that is not became right-to-left properly. If we display the languages and their countries like "English - United State", instead of "English (United State )", this problem will be gone.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-852) presenting languages and countries as
"English - United State" instead of "English (United States)" because of
right-to-left problems
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12485007 ]
Adrian Crum commented on OFBIZ-852:
-----------------------------------
Okay, I just set up my local copy for rtl direction. The strings produced by the Locale class are correct (the parenthesis look normal in the page source), but the browser displays them incorrectly. I'll look into it further.
> presenting languages and countries as "English - United State" instead of "English (United States)" because of right-to-left problems
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-852
> URL: https://issues.apache.org/jira/browse/OFBIZ-852
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Reporter: Majid Kalkatechi
> Priority: Trivial
> Attachments: header.ftl, header.patch
>
>
> In right-to-left languages(like Farsi,Arabic,...), language options will became like : ")English (United State ", this is because of parenthesis that is not became right-to-left properly. If we display the languages and their countries like "English - United State", instead of "English (United State )", this problem will be gone.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-852) presenting languages and countries as
"English - United State" instead of "English (United States)" because of
right-to-left problems
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacopo Cappellato closed OFBIZ-852.
-----------------------------------
Resolution: Fixed
> presenting languages and countries as "English - United State" instead of "English (United States)" because of right-to-left problems
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-852
> URL: https://issues.apache.org/jira/browse/OFBIZ-852
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Reporter: Majid Kalkatechi
> Priority: Trivial
> Attachments: header.ftl, header.patch
>
>
> In right-to-left languages(like Farsi,Arabic,...), language options will became like : ")English (United State ", this is because of parenthesis that is not became right-to-left properly. If we display the languages and their countries like "English - United State", instead of "English (United State )", this problem will be gone.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-852) presenting languages and countries as
"English - United State" instead of "English (United States)" because of
right-to-left problems
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12485016 ]
Adrian Crum commented on OFBIZ-852:
-----------------------------------
Chris,
I agree that more work is needed to fully implement a rtl capable version of OFBiz. But the problem being addressed here is very specific and I have confirmed it's a problem. The problem exists only within the <select> HTML element.
> presenting languages and countries as "English - United State" instead of "English (United States)" because of right-to-left problems
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-852
> URL: https://issues.apache.org/jira/browse/OFBIZ-852
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Reporter: Majid Kalkatechi
> Priority: Trivial
> Attachments: header.ftl, header.patch
>
>
> In right-to-left languages(like Farsi,Arabic,...), language options will became like : ")English (United State ", this is because of parenthesis that is not became right-to-left properly. If we display the languages and their countries like "English - United State", instead of "English (United State )", this problem will be gone.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-852) presenting languages and countries as
"English - United State" instead of "English (United States)" because of
right-to-left problems
Posted by "Chris Howe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12485014 ]
Chris Howe commented on OFBIZ-852:
----------------------------------
After changing the direction to rtl in the body tag, my first impression is that your ultimate solution for right to left languages is going to need to be much more involved than simply the single declaration. I'm not even convinced that it can be solved satisfactorily with CSS alone.
In regards to #2, my point is that English (United States) in the drop down should aloways disply both ltr and aligned left regardless of what the current locale is. Likewise, Arabic (Nationality) should always read rtl and be right aligned. This would suggest that there is a conditional on the <option class=""> or <option lang=""> in the template.
The <option lang=""> seems like a more robust solution (and naturally carry over to additional elements) as if the browser doesn't do anything with the information, javascript can play with it as the language setting will be in the DOM for each element that needs it.
There is an additional CSS property (does not work on opera or safari)
unicode-bidi: bidi-override;
That along with rtl will reverse the order of the characters.
http://www.topxml.com/css/css_property_unicode-bidi.asp
I don't know if this is beneficial or not as I'm unable to read any right to left language.
> presenting languages and countries as "English - United State" instead of "English (United States)" because of right-to-left problems
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-852
> URL: https://issues.apache.org/jira/browse/OFBIZ-852
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Reporter: Majid Kalkatechi
> Priority: Trivial
> Attachments: header.ftl, header.patch
>
>
> In right-to-left languages(like Farsi,Arabic,...), language options will became like : ")English (United State ", this is because of parenthesis that is not became right-to-left properly. If we display the languages and their countries like "English - United State", instead of "English (United State )", this problem will be gone.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.