You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2017/05/16 19:28:59 UTC
Review Request 59318: Replace in EXPECT with an ASSERT in
master_tests to avoid segfaults.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59318/
-----------------------------------------------------------
Review request for mesos and Gilbert Song.
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/tests/master_tests.cpp 37a54138b03229778bc62501532e698e87760218
Diff: https://reviews.apache.org/r/59318/diff/1/
Testing
-------
Make check with an without the patch.
Thanks,
Kapil Arya
Re: Review Request 59318: Replace an EXPECT with an ASSERT in
master_tests to avoid segfaults.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59318/#review175337
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On May 16, 2017, 7:28 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59318/
> -----------------------------------------------------------
>
> (Updated May 16, 2017, 7:28 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 37a54138b03229778bc62501532e698e87760218
>
>
> Diff: https://reviews.apache.org/r/59318/diff/1/
>
>
> Testing
> -------
>
> Make check with an without the patch.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 59318: Replace in EXPECT with an ASSERT in
master_tests to avoid segfaults.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59318/#review175739
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On May 22, 2017, 1:55 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59318/
> -----------------------------------------------------------
>
> (Updated May 22, 2017, 1:55 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replace in EXPECT with an ASSERT in master_tests to avoid segfaults.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 97d828365489fc10a0260622f7e96627528a324d
>
>
> Diff: https://reviews.apache.org/r/59318/diff/2/
>
>
> Testing
> -------
>
> Make check with an without the patch.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 59318: Replace in EXPECT with an ASSERT in
master_tests to avoid segfaults.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59318/
-----------------------------------------------------------
(Updated May 22, 2017, 4:55 p.m.)
Review request for mesos and Gilbert Song.
Changes
-------
Addressed Gilbert's comments
Summary (updated)
-----------------
Replace in EXPECT with an ASSERT in master_tests to avoid segfaults.
Repository: mesos
Description (updated)
-------
Replace in EXPECT with an ASSERT in master_tests to avoid segfaults.
Diffs (updated)
-----
src/tests/master_tests.cpp 97d828365489fc10a0260622f7e96627528a324d
Diff: https://reviews.apache.org/r/59318/diff/2/
Changes: https://reviews.apache.org/r/59318/diff/1-2/
Testing
-------
Make check with an without the patch.
Thanks,
Kapil Arya
Re: Review Request 59318: Replace an EXPECT with an ASSERT in
master_tests to avoid segfaults.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59318/#review175347
-----------------------------------------------------------
Fix it, then Ship it!
Please grep it. There is another one at #L4097.
src/tests/master_tests.cpp
Line 6289 (original), 6289 (patched)
<https://reviews.apache.org/r/59318/#comment248799>
Should we fix the other two `EXPECT_` in this file?
- Gilbert Song
On May 16, 2017, 12:28 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59318/
> -----------------------------------------------------------
>
> (Updated May 16, 2017, 12:28 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 37a54138b03229778bc62501532e698e87760218
>
>
> Diff: https://reviews.apache.org/r/59318/diff/1/
>
>
> Testing
> -------
>
> Make check with an without the patch.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 59318: Replace an EXPECT with an ASSERT in
master_tests to avoid segfaults.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59318/#review175183
-----------------------------------------------------------
Patch looks great!
Reviews applied: [58923, 58924, 58925, 58759, 58760, 58999, 59000, 59001, 59318]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 16, 2017, 7:28 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59318/
> -----------------------------------------------------------
>
> (Updated May 16, 2017, 7:28 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 37a54138b03229778bc62501532e698e87760218
>
>
> Diff: https://reviews.apache.org/r/59318/diff/1/
>
>
> Testing
> -------
>
> Make check with an without the patch.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 59318: Replace an EXPECT with an ASSERT in
master_tests to avoid segfaults.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59318/#review175454
-----------------------------------------------------------
Bad patch!
Reviews applied: [59318, 59001, 59000, 58999, 58760, 58759, 58925, 58924, 58923]
Failed command: python support/apply-reviews.py -n -r 59000
Error:
error: patch failed: src/slave/containerizer/mesos/containerizer.cpp:353
error: src/slave/containerizer/mesos/containerizer.cpp: patch does not apply
Full log: NotAvailableYet\console
- Mesos Reviewbot Windows
On May 16, 2017, 7:28 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59318/
> -----------------------------------------------------------
>
> (Updated May 16, 2017, 7:28 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 37a54138b03229778bc62501532e698e87760218
>
>
> Diff: https://reviews.apache.org/r/59318/diff/1/
>
>
> Testing
> -------
>
> Make check with an without the patch.
>
>
> Thanks,
>
> Kapil Arya
>
>