You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/08/20 20:20:58 UTC

[GitHub] [incubator-tvm] yongwww commented on a change in pull request #6314: [Relay] Support for PyTorch Non-Maximum Suppression

yongwww commented on a change in pull request #6314:
URL: https://github.com/apache/incubator-tvm/pull/6314#discussion_r474250004



##########
File path: tests/python/frontend/pytorch/test_forward.py
##########
@@ -1606,6 +1633,39 @@ def verify_script_model(pt_model, ishapes):
                                     rtol=1e-5, atol=1e-5)
 
 
+def verify_trace_model(traced_model, ishapes, idata=None):

Review comment:
       @masahi did you mean removing `verify_trace_model` and adding `verify_model_on_vm` to serve as a common function for vm execution?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org