You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/04/08 20:19:27 UTC
[GitHub] [accumulo] andrewglowacki opened a new issue #1582: Add vscode
directory/files to .gitignore and apache-rat ignore.
andrewglowacki opened a new issue #1582: Add vscode directory/files to .gitignore and apache-rat ignore.
URL: https://github.com/apache/accumulo/issues/1582
VSCode creates a .vscode directory and .factorypath files that are flagged by the rat plugin, and git as changes. These should be ignored/excluded
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [accumulo] ctubbsii commented on issue #1582: Add vscode
directory/files to .gitignore and apache-rat ignore.
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on issue #1582: Add vscode directory/files to .gitignore and apache-rat ignore.
URL: https://github.com/apache/accumulo/issues/1582#issuecomment-611185398
> Whoops! Yea, I'm going to submit a PR when this build is complete. I wasn't sure, but next time I'll just submit a PR. Thanks for the clarification!
No problem. Just trying to make sure people don't do more work than they have to. Thanks for contributing! :smiley_cat:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [accumulo] ctubbsii closed issue #1582: Add vscode directory/files
to .gitignore and apache-rat ignore.
Posted by GitBox <gi...@apache.org>.
ctubbsii closed issue #1582: Add vscode directory/files to .gitignore and apache-rat ignore.
URL: https://github.com/apache/accumulo/issues/1582
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [accumulo] andrewglowacki commented on issue #1582: Add vscode
directory/files to .gitignore and apache-rat ignore.
Posted by GitBox <gi...@apache.org>.
andrewglowacki commented on issue #1582: Add vscode directory/files to .gitignore and apache-rat ignore.
URL: https://github.com/apache/accumulo/issues/1582#issuecomment-611182877
Whoops! Yea, I'm going to submit a PR when this build is complete. I wasn't sure, but next time I'll just submit a PR. Thanks for the clarification!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [accumulo] ctubbsii commented on issue #1582: Add vscode
directory/files to .gitignore and apache-rat ignore.
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on issue #1582: Add vscode directory/files to .gitignore and apache-rat ignore.
URL: https://github.com/apache/accumulo/issues/1582#issuecomment-611180688
@andrewglowacki Are you filing this issue to document it for later, or are you interested in submitting a pull request to address this?
If you're just documenting the issue for potential later work (perhaps by some other volunteer), or if the work might be substantial enough to discuss first, in order to avoid potentially wasted or misdirected effort, then creating an issue first might make sense.
If the latter, especially for very small stuff, there is no need to create an issue first. You can just create the pull request, since pull requests are their own issues on GitHub.
It's up to you. I just wanted to make sure you knew it wasn't required to have a separate ticket for each PR, just for the sake of creating tickets. :smiley_cat:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services