You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "hainq1902 (via GitHub)" <gi...@apache.org> on 2023/08/22 18:50:42 UTC
[GitHub] [camel] hainq1902 opened a new pull request, #11177: CAMEL-19743: upgrade grpc to 1.57.1
hainq1902 opened a new pull request, #11177:
URL: https://github.com/apache/camel/pull/11177
# Description
<!--
- Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
-->
Upgrade grpc to 1.57.1 to fix CAMEL-19743.
# Target
- [x] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
# Tracking
- [x] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [x] I checked that each commit in the pull request has a meaningful subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
-->
- [x] I have run `mvn clean install -DskipTests` locally and I have committed all auto-generated changes
<!--
You can run the aforementioned command in your module so that the build auto-formats your code. This will also be verified as part of the checks and your PR may be rejected if if there are uncommited changes after running `mvn clean install -DskipTests`.
You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd closed pull request #11177: CAMEL-19743: upgrade grpc to 1.57.1
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd closed pull request #11177: CAMEL-19743: upgrade grpc to 1.57.1
URL: https://github.com/apache/camel/pull/11177
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #11177: CAMEL-19743: upgrade grpc to 1.57.1
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #11177:
URL: https://github.com/apache/camel/pull/11177#issuecomment-1690280190
You can try to upgrade but not on 3.21.x, on 3.x, because this is a breaking change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #11177: CAMEL-19743: upgrade grpc to 1.57.1
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11177:
URL: https://github.com/apache/camel/pull/11177#issuecomment-1688790517
:robot: The Apache Camel test robot will run the tests for you :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] Quang-Hai-Nguyen commented on pull request #11177: CAMEL-19743: upgrade grpc to 1.57.1
Posted by "Quang-Hai-Nguyen (via GitHub)" <gi...@apache.org>.
Quang-Hai-Nguyen commented on PR #11177:
URL: https://github.com/apache/camel/pull/11177#issuecomment-1690126301
> The PR is good, but the jump is too big from 1.48 to 1.57.1, you should do this upgrade on main branch and then we should have a look if we could backport or not.
We already have it on main branch by merging https://github.com/apache/camel/pull/10995.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] hainq1902 commented on pull request #11177: CAMEL-19743: upgrade grpc to 1.57.1
Posted by "hainq1902 (via GitHub)" <gi...@apache.org>.
hainq1902 commented on PR #11177:
URL: https://github.com/apache/camel/pull/11177#issuecomment-1688885940
Hi @oscerd,
This file didn't pass checkstyle [SensitiveUtils.java](https://github.com/apache/camel/blob/camel-3.21.x/core/camel-util/src/main/java/org/apache/camel/util/SensitiveUtils.java) but it isn't in the scope of this PR either.
Could you tell me what I should do to have this PR approved & merged ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #11177: CAMEL-19743: upgrade grpc to 1.57.1
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #11177:
URL: https://github.com/apache/camel/pull/11177#issuecomment-1688790225
/component-tests camel-grpc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #11177: CAMEL-19743: upgrade grpc to 1.57.1
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #11177:
URL: https://github.com/apache/camel/pull/11177#issuecomment-1688891717
No faults on your side. The pr is fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #11177: CAMEL-19743: upgrade grpc to 1.57.1
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #11177:
URL: https://github.com/apache/camel/pull/11177#issuecomment-1691997386
Let me close this one for the moment. Eventually re-open on 3.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #11177: CAMEL-19743: upgrade grpc to 1.57.1
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11177:
URL: https://github.com/apache/camel/pull/11177#issuecomment-1688861797
:no_entry_sign: There are (likely) no changes in core core to be tested in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #11177: CAMEL-19743: upgrade grpc to 1.57.1
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11177:
URL: https://github.com/apache/camel/pull/11177#issuecomment-1688861776
:no_entry_sign: There are (likely) no components to be tested in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org