[GitHub] [carbondata] akashrn5 commented on a change in pull request #4063: [CARBONDATA-4095] Fix Select Query with SI filter fails, when columnDrift is Set

[GitBox <gi...@apache.org>]

akashrn5 commented on a change in pull request #4063:
URL: https://github.com/apache/carbondata/pull/4063#discussion_r547702404



##########
File path: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonInputFormat.java
##########
@@ -683,6 +683,8 @@ public QueryModel createQueryModel(InputSplit inputSplit, TaskAttemptContext tas
     }
     if (indexFilter != null) {
       checkAndAddImplicitExpression(indexFilter.getExpression(), inputSplit);
+      // process filter expression after adding implicit expression
+      indexFilter.processFilterExpression();

Review comment:
       in `Querymodelbuilder.build()` we call `processFilterExpression` with check of columndrift, so here if we call process, then in case of no column drift , two times will be called, so please refactor to call this only in case of columndrift true 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org