[jira] [Commented] (NIFI-2839) Add a confirmation dialog when deleting a Controller Service

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-2839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15795440#comment-15795440 ] 

ASF GitHub Bot commented on NIFI-2839:
--------------------------------------

GitHub user pvillard31 opened a pull request:

    https://github.com/apache/nifi/pull/1384

    NIFI-2839 Add a confirmation dialog when deleting a Controller Service

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [X] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [X] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pvillard31/nifi NIFI-2839

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1384.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1384
    
----
commit 6eb592bfd032404d402ccc9d83e2c4d524399b16
Author: Pierre Villard <pi...@gmail.com>
Date:   2017-01-03T16:24:12Z

    NIFI-2839 Add a confirmation dialog when deleting a Controller Service

----


> Add a confirmation dialog when deleting a Controller Service
> ------------------------------------------------------------
>
>                 Key: NIFI-2839
>                 URL: https://issues.apache.org/jira/browse/NIFI-2839
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core UI
>    Affects Versions: 1.0.0
>            Reporter: Andrew Lim
>            Priority: Minor
>              Labels: UI
>
> As soon as the user selects a Controller Service for deletion it is immediately deleted.  There should be a warning/confirmation dialog to make sure this is the user's intended selection/action.
> This is especially needed because it is possible in the UI to create Controller Services with the same name, so it can be ambiguous which one is being selected for deletion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)