You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "rhaetor (via GitHub)" <gi...@apache.org> on 2025/11/24 14:56:31 UTC

[PR] Fixed inconsistent comments for include sections. [camel]

rhaetor opened a new pull request, #20040:
URL: https://github.com/apache/camel/pull/20040

   # Description
   
   The comments for the included options are out of sync with the actual include statements. This PR moves the header-options include statement into its proper place. 
   
   Also corrects formatting to make it consistent.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fixed inconsistent comments for include sections. [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20040:
URL: https://github.com/apache/camel/pull/20040#issuecomment-3571203420

   :star2: Thank you for your contribution to the Apache Camel project! :star2: 
   
   :robot: CI automation will test this PR automatically.
   
   :camel: Apache Camel Committers, please review the following items:
   
   * First-time contributors **require MANUAL approval** for the GitHub Actions to run
   
   * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
   
   * You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
   
   * Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary. 
   
   * :warning: Be careful when sharing logs. Review their contents before sharing them publicly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fixed inconsistent comments for include sections. [camel]

Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #20040:
URL: https://github.com/apache/camel/pull/20040#issuecomment-3571749593

   its likely something ala
   https://github.com/apache/camel/pull/20041
   
   But then would need to remove all those // START // END for all the components. I just did this only for 1 component to give it a try first


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fixed inconsistent comments for include sections. [camel]

Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #20040:
URL: https://github.com/apache/camel/pull/20040#issuecomment-3571693538

   Sorry but those files are auto-generated and as such this PR wont work.
   Its a bit tricky these doc files and its not easy to move things around.
   
   Some years ago this was change as the html site has some javascript magic that renders those tables, and there are some left overs in the original adoc files that are hanging.
   
   So it looks like that these can be removed instead
   
   ```
   // component-configure options: START
   
   // component-configure options: END
   ```
   
   And
   ```
   // endpoint options: START
   
   // endpoint options: END
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fixed inconsistent comments for include sections. [camel]

Posted by "rhaetor (via GitHub)" <gi...@apache.org>.
rhaetor commented on PR #20040:
URL: https://github.com/apache/camel/pull/20040#issuecomment-3571944120

   Maybe all comments can be removed, if they aren't used. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fixed inconsistent comments for include sections. [camel]

Posted by "rhaetor (via GitHub)" <gi...@apache.org>.
rhaetor closed pull request #20040: Fixed inconsistent comments for include sections.
URL: https://github.com/apache/camel/pull/20040


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org