[jira] [Commented] (IMPALA-6908) IsConnResetTException() should include ECONNRESET

["Sailesh Mukil (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-6908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16458815#comment-16458815 ] 

Sailesh Mukil commented on IMPALA-6908:
---------------------------------------

I looked at this for a bit. We match with "SSL_read: Connection reset by peer", which is the version of the same ECONNRESET error while using TLS. I think we can safely add plain ECONNRESET to the list for clusters that do not have TLS turned on.

> IsConnResetTException() should include ECONNRESET
> -------------------------------------------------
>
>                 Key: IMPALA-6908
>                 URL: https://issues.apache.org/jira/browse/IMPALA-6908
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Distributed Exec
>    Affects Versions: Impala 2.10.0, Impala 2.11.0, Impala 3.0, Impala 2.12.0
>            Reporter: Michael Ho
>            Assignee: Sailesh Mukil
>            Priority: Major
>
> {{IsConnReset()}} aims to check if the given exception is due to a stale connection. Apparently, it's missing the case in which the error code is ECONNRESET.
> {noformat}
> bool IsConnResetTException(const TTransportException& e) {
>   // Strings taken from TTransport::readAll(). This happens iff TSocket::read() returns 0.
>   // As readAll() is reading non-zero length payload, this can only mean recv() called
>   // by read() returns 0. According to man page of recv(), this implies a stream socket
>   // peer has performed an orderly shutdown.
>   return (e.getType() == TTransportException::END_OF_FILE &&
>              strstr(e.what(), "No more data to read.") != nullptr) ||
>          (e.getType() == TTransportException::INTERNAL_ERROR &&
>              strstr(e.what(), "SSL_read: Connection reset by peer") != nullptr);
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org