You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "dnskr (via GitHub)" <gi...@apache.org> on 2023/04/13 16:59:56 UTC
[GitHub] [superset] dnskr opened a new pull request, #23681: chore(helm): Reformat helm chart templates
dnskr opened a new pull request, #23681:
URL: https://github.com/apache/superset/pull/23681
### SUMMARY
The PR reformats chart templates to one style with more readable blocks and indents.
The PR does not change any functionality of the chart, so there is no chart version upgrade.
Similar changes: https://github.com/apache/airflow/pull/29917 https://github.com/apache/airflow/pull/29941 https://github.com/apache/airflow/pull/30312
### TESTING INSTRUCTIONS
The following command install the chart
```shell
helm install superset helm/superset
```
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dnskr commented on pull request #23681: chore(helm): Reformat helm chart templates
Posted by "dnskr (via GitHub)" <gi...@apache.org>.
dnskr commented on PR #23681:
URL: https://github.com/apache/superset/pull/23681#issuecomment-1511860869
Unfortunately no - only manual work, only hardcore :)
I'm looking for a way to automate it and I'll come back with the PR if I find. There is a similar issue https://github.com/apache/airflow/issues/30546.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda commented on pull request #23681: chore(helm): Reformat helm chart templates
Posted by "craig-rueda (via GitHub)" <gi...@apache.org>.
craig-rueda commented on PR #23681:
URL: https://github.com/apache/superset/pull/23681#issuecomment-1510507694
Did you use a tool to perform the reformat? I ask because if so, we should probably perform a lint step in CI to enforce some rules around formatting :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda merged pull request #23681: chore(helm): Reformat helm chart templates
Posted by "craig-rueda (via GitHub)" <gi...@apache.org>.
craig-rueda merged PR #23681:
URL: https://github.com/apache/superset/pull/23681
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org