[GitHub] KellenSunderland commented on a change in pull request #11302: [MXNET-553] Restructure dockcross dockerfiles to fix caching

[GitBox <gi...@apache.org>]

KellenSunderland commented on a change in pull request #11302: [MXNET-553] Restructure dockcross dockerfiles to fix caching
URL: https://github.com/apache/incubator-mxnet/pull/11302#discussion_r195911652
 
 

 ##########
 File path: ci/docker/install/deb_ubuntu_ccache.sh
 ##########
 @@ -43,7 +43,9 @@ git clone --recursive -b v3.4.2 https://github.com/ccache/ccache.git
 cd ccache
 
 ./autogen.sh
-./configure
+# Manually specify x86 gcc versions so that this script remains compatible with dockcross (which uses an ARM based gcc
+# by default).
+CC=/usr/bin/gcc CXX=/usr/bin/g++ ./configure
 
 Review comment:
   We want to ensure we're maintaining the CC and CXX env vars from the 'dockcross/linux-armv7' image, so to do this we'd have to store those and then restore them.  Seems more complicated than just overriding them for a single command to me.
   
   What would be the advantage, readability?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services