You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by ToivoAdams <gi...@git.apache.org> on 2016/03/25 18:03:04 UTC
[GitHub] nifi pull request: NIFI-1685 Optimize database Junit tests to redu...
GitHub user ToivoAdams opened a pull request:
https://github.com/apache/nifi/pull/304
NIFI-1685 Optimize database Junit tests to reduce execution time.
TestPutSQL and TestJdbcCommon are now optimized.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ToivoAdams/nifi NIFI-1685
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/304.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #304
----
commit a01ad7131e77e11490659ae62abced79980dc622
Author: Toivo Adams <to...@gmail.com>
Date: 2016-03-25T16:51:00Z
NIFI-1685 Optimize database Junit tests to reduce execution time.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1685 Optimize database Junit tests to redu...
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/304#discussion_r57464551
--- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestPutSQL.java ---
@@ -144,6 +168,7 @@ public void testInsertWithGeneratedKeys() throws InitializationException, Proces
@Test
public void testFailInMiddleWithBadStatement() throws InitializationException, ProcessException, SQLException, IOException {
final TestRunner runner = TestRunners.newTestRunner(PutSQL.class);
+/****
--- End diff --
I'd suggest to simply remove all commented blocks for better visibility, don't you think ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1685 Optimize database Junit tests to redu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/304
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1685 Optimize database Junit tests to redu...
Posted by ToivoAdams <gi...@git.apache.org>.
Github user ToivoAdams commented on a diff in the pull request:
https://github.com/apache/nifi/pull/304#discussion_r57464949
--- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestPutSQL.java ---
@@ -144,6 +168,7 @@ public void testInsertWithGeneratedKeys() throws InitializationException, Proces
@Test
public void testFailInMiddleWithBadStatement() throws InitializationException, ProcessException, SQLException, IOException {
final TestRunner runner = TestRunners.newTestRunner(PutSQL.class);
+/****
--- End diff --
You are right, my bad, I forgot to remove.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1685 Optimize database Junit tests to redu...
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the pull request:
https://github.com/apache/nifi/pull/304#issuecomment-202778901
Tested and contrib-checked.
Before:
Running org.apache.nifi.processors.standard.TestPutSQL
Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.33 sec
Running org.apache.nifi.processors.standard.util.TestJdbcCommon
Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.812 sec
Running org.apache.nifi.processors.standard.TestExecuteSQL
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.187 sec
Running org.apache.nifi.processors.standard.util.TestJdbcHugeStream
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.814 sec
Running org.apache.nifi.processors.standard.QueryDatabaseTableTest
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.631 sec
Total = 17,774 sec
After:
Running org.apache.nifi.processors.standard.TestPutSQL
Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.993 sec
Running org.apache.nifi.processors.standard.util.TestJdbcCommon
Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.46 sec
Running org.apache.nifi.processors.standard.TestExecuteSQL
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.922 sec
Running org.apache.nifi.processors.standard.util.TestJdbcHugeStream
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.072 sec
Running org.apache.nifi.processors.standard.QueryDatabaseTableTest
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.21 sec
Total = 12,657 sec
Not a huge difference but it is better. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---