You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "MonkeyCanCode (via GitHub)" <gi...@apache.org> on 2026/07/07 04:36:30 UTC
[PR] Removed pinned version for org.graalvm.shadowed:icu4j [polaris]
MonkeyCanCode opened a new pull request, #4989:
URL: https://github.com/apache/polaris/pull/4989
<!--
๐ Describe what changes you're proposing, especially breaking or user-facing changes.
๐ See https://github.com/apache/polaris/blob/main/CONTRIBUTING.md for more.
-->
`org.graalvm.shadowed:icu4j` had been causing failed renovate jobs twice already (earlier was https://github.com/apache/polaris/pull/4272 and now https://github.com/apache/polaris/pull/4943). I am not sure if we really needed to pinned to a specific version. If not, perhaps we should remove the pinned version so renovate bot can handle this package as rest of the other packages.
## Checklist
- [x] ๐ก๏ธ Don't disclose security issues! (contact security@apache.org)
- [x] ๐ Clearly explained why the changes are needed, or linked related issues: Fixes #
- [x] ๐งช Added/updated tests with good coverage, or manually tested (and explained how)
- [x] ๐ก Added comments for complex logic
- [x] ๐งพ Updated `CHANGELOG.md` (if needed)
- [x] ๐ Updated documentation in `site/content/in-dev/unreleased` (if needed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Removed pinned version for org.graalvm.shadowed:icu4j [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on code in PR #4989:
URL: https://github.com/apache/polaris/pull/4989#discussion_r3538002862
##########
gradle/license/allowed-licenses.json:
##########
@@ -97,8 +97,7 @@
},
{
"moduleLicense": "Unicode/ICU License",
- "moduleName": "org.graalvm.shadowed:icu4j",
- "moduleVersion": "25.0.3"
+ "moduleName": "org.graalvm.shadowed:icu4j"
Review Comment:
Should we also remove the module name? Seems like the license part is the only thing we care here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Removed pinned version for org.graalvm.shadowed:icu4j [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #4989:
URL: https://github.com/apache/polaris/pull/4989#discussion_r3540204942
##########
gradle/license/allowed-licenses.json:
##########
@@ -97,8 +97,7 @@
},
{
"moduleLicense": "Unicode/ICU License",
- "moduleName": "org.graalvm.shadowed:icu4j",
- "moduleVersion": "25.0.3"
+ "moduleName": "org.graalvm.shadowed:icu4j"
Review Comment:
@flyrain : I propose to merge "as is" to unblock GraalVM upgrade since majority of reviewers seem to be ok with this change. Let's make another PR for removing the module from this config entry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Removed pinned version for org.graalvm.shadowed:icu4j [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on PR #4989:
URL: https://github.com/apache/polaris/pull/4989#issuecomment-4900726735
cc @sneethiraj
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Removed pinned version for org.graalvm.shadowed:icu4j [polaris]
Posted by "mneethiraj (via GitHub)" <gi...@apache.org>.
mneethiraj commented on PR #4989:
URL: https://github.com/apache/polaris/pull/4989#issuecomment-4905914275
@MonkeyCanCode - removing pinned version in `allowed-licenses.json` is good. The version packaged is controlled in `gradle/libs.versions.toml`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Removed pinned version for org.graalvm.shadowed:icu4j [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b merged PR #4989:
URL: https://github.com/apache/polaris/pull/4989
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Removed pinned version for org.graalvm.shadowed:icu4j [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #4989:
URL: https://github.com/apache/polaris/pull/4989#discussion_r3540129834
##########
gradle/license/allowed-licenses.json:
##########
@@ -97,8 +97,7 @@
},
{
"moduleLicense": "Unicode/ICU License",
- "moduleName": "org.graalvm.shadowed:icu4j",
- "moduleVersion": "25.0.3"
+ "moduleName": "org.graalvm.shadowed:icu4j"
Review Comment:
@jbonofre : WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Removed pinned version for org.graalvm.shadowed:icu4j [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #4989:
URL: https://github.com/apache/polaris/pull/4989#discussion_r3538077513
##########
gradle/license/allowed-licenses.json:
##########
@@ -97,8 +97,7 @@
},
{
"moduleLicense": "Unicode/ICU License",
- "moduleName": "org.graalvm.shadowed:icu4j",
- "moduleVersion": "25.0.3"
+ "moduleName": "org.graalvm.shadowed:icu4j"
Review Comment:
Keeping the `Unicode/ICU License` permission scoped to `icu4j` sounds reasonable to me. It's not a common license. I think we should review new use cases individually if/when they come up.
+1 to removing `moduleVersion`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Removed pinned version for org.graalvm.shadowed:icu4j [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on code in PR #4989:
URL: https://github.com/apache/polaris/pull/4989#discussion_r3538191096
##########
gradle/license/allowed-licenses.json:
##########
@@ -97,8 +97,7 @@
},
{
"moduleLicense": "Unicode/ICU License",
- "moduleName": "org.graalvm.shadowed:icu4j",
- "moduleVersion": "25.0.3"
+ "moduleName": "org.graalvm.shadowed:icu4j"
Review Comment:
The ASF license rule is against the license itself, instead of modules, and `Unicode/ICU License` is listed in catalog A, https://www.apache.org/legal/resolved.html#category-a. Why do we need a module name here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Removed pinned version for org.graalvm.shadowed:icu4j [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on code in PR #4989:
URL: https://github.com/apache/polaris/pull/4989#discussion_r3540278308
##########
gradle/license/allowed-licenses.json:
##########
@@ -97,8 +97,7 @@
},
{
"moduleLicense": "Unicode/ICU License",
- "moduleName": "org.graalvm.shadowed:icu4j",
- "moduleVersion": "25.0.3"
+ "moduleName": "org.graalvm.shadowed:icu4j"
Review Comment:
@dimas-b, sounds good to me. Thanks for the clarification. My comment wasn't meant to be a blocker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org