You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/17 08:41:04 UTC

[GitHub] [arrow-rs] jhorstmann commented on a diff in pull request #1571: Replace &Option with Option<&T>

jhorstmann commented on code in PR #1571:
URL: https://github.com/apache/arrow-rs/pull/1571#discussion_r851723463


##########
arrow/src/compute/kernels/substring.rs:
##########
@@ -133,7 +133,7 @@ fn generic_substring<OffsetSize: StringOffsetSizeTrait>(
 pub fn substring(
     array: &dyn Array,
     start: i64,
-    length: &Option<u64>,
+    length: Option<&u64>,

Review Comment:
   Could also consider using `Option<u64>` here since u64 is trivially copyable



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org