[jira] Commented: (OPENJPA-884) Logging oversight in DB2Dictionary

["Michael Dick (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OPENJPA-884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670331#action_12670331 ] 

Michael Dick commented on OPENJPA-884:
--------------------------------------

I think the intent was actually to use trace level logging. We're reporting an error, but one that we can recover from. The method doesn't re-throw the exception and the original intent appears to be just to recover silently. Still it's not obvious what the intent is and it needs to be fixed. 

Good catch Milosz

> Logging oversight in DB2Dictionary
> ----------------------------------
>
>                 Key: OPENJPA-884
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-884
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: logging
>    Affects Versions: 1.2.0, 1.2.1, 1.3.0, 2.0.0-M1, 2.0.0
>            Reporter: Milosz Tylenda
>            Priority: Trivial
>         Attachments: OPENJPA-884.patch
>
>
> There is a small oversight in DB2Dictionary - there is a check whether TRACE level is enabled and then an exception is logged on ERROR level.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.