You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Tim Moloney (JIRA)" <ji...@apache.org> on 2007/03/10 13:32:09 UTC
[jira] Created: (FELIX-250) Modify main to copy framework
properties from the system properties.
Modify main to copy framework properties from the system properties.
--------------------------------------------------------------------
Key: FELIX-250
URL: https://issues.apache.org/jira/browse/FELIX-250
Project: Felix
Issue Type: Improvement
Reporter: Tim Moloney
Priority: Trivial
For convenience, allow Felix framework properties values to be set in the system properties, then have main copy them to the framework properties.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Created: (FELIX-250) Modify main to copy framework properties from the system properties.
Posted by Niclas Hedhman <ni...@hedhman.org>.
On Sunday 11 March 2007 16:26, Tim Moloney wrote:
> Am I missing something?
No, I think I was... "From system properties", I read as "to system...". Not
used to language constructs like;
frameworkproperties = systemproperties;
(Just kidding.)
Cheers
Niclas
Re: [jira] Created: (FELIX-250) Modify main to copy framework properties
from the system properties.
Posted by "Richard S. Hall" <he...@ungoverned.org>.
Tim Moloney wrote:
> Niclas Hedhman wrote:
>> On Saturday 10 March 2007 20:32, Tim Moloney (JIRA) wrote:
>>
>>> Modify main to copy framework properties from the system properties.
>>>
>>
>> IMHO, this is perhaps not such a good idea. System properties are JVM
>> global, and I think you should try to avoid overusing them. Think
>> And if you really insist, you can always add "system bundles" to
>> Felix which does this, or for that matter have your own Tim.main()
>> that does that and shoots up Felix.
>>
>> Cheers
>> Niclas
>>
>
> The only problem that I can see is if you are running more than one
> instance of the Felix class. My patch only changes the main class to
> copy the Felix system properties to the framework properties which are
> passed to its one instance of the Felix class. If you are running
> more than one instance of Felix, then you aren't using the Main class
> and my patch doesn't change anything. Am I missing something?
Yes, that is correct.
-> richard
Re: [jira] Created: (FELIX-250) Modify main to copy framework
properties from the system properties.
Posted by Tim Moloney <t....@verizon.net>.
Niclas Hedhman wrote:
> On Saturday 10 March 2007 20:32, Tim Moloney (JIRA) wrote:
>
>> Modify main to copy framework properties from the system properties.
>>
>
> IMHO, this is perhaps not such a good idea. System properties are JVM global,
> and I think you should try to avoid overusing them. Think
> And if you really insist, you can always add "system bundles" to Felix which
> does this, or for that matter have your own Tim.main() that does that and
> shoots up Felix.
>
> Cheers
> Niclas
>
The only problem that I can see is if you are running more than one
instance of the Felix class. My patch only changes the main class to
copy the Felix system properties to the framework properties which are
passed to its one instance of the Felix class. If you are running more
than one instance of Felix, then you aren't using the Main class and my
patch doesn't change anything. Am I missing something?
Tim
Re: [jira] Created: (FELIX-250) Modify main to copy framework properties from the system properties.
Posted by Niclas Hedhman <ni...@hedhman.org>.
On Saturday 10 March 2007 20:32, Tim Moloney (JIRA) wrote:
> Modify main to copy framework properties from the system properties.
IMHO, this is perhaps not such a good idea. System properties are JVM global,
and I think you should try to avoid overusing them. Think
And if you really insist, you can always add "system bundles" to Felix which
does this, or for that matter have your own Tim.main() that does that and
shoots up Felix.
Cheers
Niclas
[jira] Resolved: (FELIX-250) Modify main to copy framework
properties from the system properties.
Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard S. Hall resolved FELIX-250.
-----------------------------------
Resolution: Fixed
Assignee: Richard S. Hall
I have applied this patch. Tim, if everything looks okay, please close this issue.
> Modify main to copy framework properties from the system properties.
> --------------------------------------------------------------------
>
> Key: FELIX-250
> URL: https://issues.apache.org/jira/browse/FELIX-250
> Project: Felix
> Issue Type: Improvement
> Reporter: Tim Moloney
> Assigned To: Richard S. Hall
> Priority: Trivial
> Attachments: main-copy-props-1.patch, main-copy-props-2.patch
>
>
> For convenience, allow Felix framework properties values to be set in the system properties, then have main copy them to the framework properties.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (FELIX-250) Modify main to copy framework properties
from the system properties.
Posted by "Tim Moloney (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Moloney closed FELIX-250.
-----------------------------
> Modify main to copy framework properties from the system properties.
> --------------------------------------------------------------------
>
> Key: FELIX-250
> URL: https://issues.apache.org/jira/browse/FELIX-250
> Project: Felix
> Issue Type: Improvement
> Reporter: Tim Moloney
> Assigned To: Richard S. Hall
> Priority: Trivial
> Attachments: main-copy-props-1.patch, main-copy-props-2.patch
>
>
> For convenience, allow Felix framework properties values to be set in the system properties, then have main copy them to the framework properties.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-250) Modify main to copy framework
properties from the system properties.
Posted by "Tim Moloney (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12479836 ]
Tim Moloney commented on FELIX-250:
-----------------------------------
Should the framework properties file have precedence or should the system properties?
The patch is implemented so that the framework properties file has precedence but it may be more convenient to have the system properties override the framework properties file.
> Modify main to copy framework properties from the system properties.
> --------------------------------------------------------------------
>
> Key: FELIX-250
> URL: https://issues.apache.org/jira/browse/FELIX-250
> Project: Felix
> Issue Type: Improvement
> Reporter: Tim Moloney
> Priority: Trivial
> Attachments: main-copy-props-1.patch
>
>
> For convenience, allow Felix framework properties values to be set in the system properties, then have main copy them to the framework properties.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-250) Modify main to copy framework
properties from the system properties.
Posted by "Tim Moloney (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Moloney updated FELIX-250:
------------------------------
Attachment: main-copy-props-1.patch
Created patch to implement this.
> Modify main to copy framework properties from the system properties.
> --------------------------------------------------------------------
>
> Key: FELIX-250
> URL: https://issues.apache.org/jira/browse/FELIX-250
> Project: Felix
> Issue Type: Improvement
> Reporter: Tim Moloney
> Priority: Trivial
> Attachments: main-copy-props-1.patch
>
>
> For convenience, allow Felix framework properties values to be set in the system properties, then have main copy them to the framework properties.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-250) Modify main to copy framework
properties from the system properties.
Posted by "Tim Moloney (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Moloney updated FELIX-250:
------------------------------
Attachment: main-copy-props-2.patch
More consice patch that handles the numbers in the 'felix.auto.start.x' properties.
> Modify main to copy framework properties from the system properties.
> --------------------------------------------------------------------
>
> Key: FELIX-250
> URL: https://issues.apache.org/jira/browse/FELIX-250
> Project: Felix
> Issue Type: Improvement
> Reporter: Tim Moloney
> Priority: Trivial
> Attachments: main-copy-props-1.patch, main-copy-props-2.patch
>
>
> For convenience, allow Felix framework properties values to be set in the system properties, then have main copy them to the framework properties.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-250) Modify main to copy framework
properties from the system properties.
Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12479928 ]
Richard S. Hall commented on FELIX-250:
---------------------------------------
I guess for what you are trying to achieve, it makes more sense for system properties to have precedence.
> Modify main to copy framework properties from the system properties.
> --------------------------------------------------------------------
>
> Key: FELIX-250
> URL: https://issues.apache.org/jira/browse/FELIX-250
> Project: Felix
> Issue Type: Improvement
> Reporter: Tim Moloney
> Priority: Trivial
> Attachments: main-copy-props-1.patch, main-copy-props-2.patch
>
>
> For convenience, allow Felix framework properties values to be set in the system properties, then have main copy them to the framework properties.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.