[jira] [Commented] (ARROW-17686) [C++] AsofJoinBasicParams has no gtest printer defined, leading to valgrind errors

["Percy Camilo Triveño Aucahuasi (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-17686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603913#comment-17603913 ] 

Percy Camilo Triveño Aucahuasi commented on ARROW-17686:
--------------------------------------------------------

Any ideas about how I can reproduce this issue?

I tried to run this unit test using valgrind in a docker amd64 container and also on a PC x86_64 machine (both linux ubuntu latest) but the results are fine:
{code:java}
==61156== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0){code}
but in the linked report from the ticket's description we get errors:
{code:java}
2022-09-12T02:07:26.4886794Z ==19253== ERROR SUMMARY: 2112 errors from 4 contexts (suppressed: 0 from 0) {code}
Note: Also I tried to run this on macOS (arm64 arch) and also didn't get any errors.

> [C++] AsofJoinBasicParams has no gtest printer defined, leading to valgrind errors
> ----------------------------------------------------------------------------------
>
>                 Key: ARROW-17686
>                 URL: https://issues.apache.org/jira/browse/ARROW-17686
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: C++
>            Reporter: Weston Pace
>            Assignee: Percy Camilo Triveño Aucahuasi
>            Priority: Major
>
> Valgrind is currently failing on arrow-compute-asof-join-node-test: https://dev.azure.com/ursacomputing/crossbow/_build/results?buildId=34147&view=logs&j=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb&t=d9b15392-e4ce-5e4c-0c8c-b69645229181&l=4118
> The issue appears to be that AsofJoinBasicParams has no gtest printer and so gtest is using the default universal-printer which doesn't really play well with valgrind.  We should add a custom PrintTo method for AsofJoinBasicParams per: https://github.com/google/googletest/blob/main/googletest/include/gtest/gtest-printers.h



--
This message was sent by Atlassian Jira
(v8.20.10#820010)