You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2023/01/03 13:58:50 UTC
[GitHub] [incubator-devlake] mindlesscloud opened a new pull request, #4090: fix: fix the canceling does not work when SkipOnFail is set to true
mindlesscloud opened a new pull request, #4090:
URL: https://github.com/apache/incubator-devlake/pull/4090
### Summary
Fix the bug that canceling does not work when `SkipOnFail` is set to true
- make sure every task returns the error `context.Canceled` when it is canceled
- if the error is`context.Canceled`, return it despite the value of `SkipOnFail`
### Screenshots
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 commented on a diff in pull request #4090: fix: fix the canceling does not work when SkipOnFail is set to true
Posted by GitBox <gi...@apache.org>.
warren830 commented on code in PR #4090:
URL: https://github.com/apache/incubator-devlake/pull/4090#discussion_r1061000389
##########
plugins/helper/api_collector.go:
##########
@@ -168,7 +168,8 @@ func (collector *ApiCollector) Execute() errors.Error {
break
}
}
- input, err := iterator.Fetch()
+ var input interface{}
+ input, err = iterator.Fetch()
Review Comment:
What does this fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 merged pull request #4090: fix: fix the canceling does not work when SkipOnFail is set to true
Posted by GitBox <gi...@apache.org>.
warren830 merged PR #4090:
URL: https://github.com/apache/incubator-devlake/pull/4090
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] mindlesscloud commented on a diff in pull request #4090: fix: fix the canceling does not work when SkipOnFail is set to true
Posted by GitBox <gi...@apache.org>.
mindlesscloud commented on code in PR #4090:
URL: https://github.com/apache/incubator-devlake/pull/4090#discussion_r1061079753
##########
plugins/helper/api_collector.go:
##########
@@ -168,7 +168,8 @@ func (collector *ApiCollector) Execute() errors.Error {
break
}
}
- input, err := iterator.Fetch()
+ var input interface{}
+ input, err = iterator.Fetch()
Review Comment:
this snippet is sitting inside a for loop, the statement `input, err := iterator.Fetch()` would declare a new local variable `err` which shadows the original `err`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 commented on a diff in pull request #4090: fix: fix the canceling does not work when SkipOnFail is set to true
Posted by GitBox <gi...@apache.org>.
warren830 commented on code in PR #4090:
URL: https://github.com/apache/incubator-devlake/pull/4090#discussion_r1061001102
##########
plugins/helper/api_collector.go:
##########
@@ -168,7 +168,8 @@ func (collector *ApiCollector) Execute() errors.Error {
break
}
}
- input, err := iterator.Fetch()
+ var input interface{}
+ input, err = iterator.Fetch()
Review Comment:
I know there is some issue which I cannot regenerate in jenkins, does this relate to it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org