You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2020/02/26 16:19:59 UTC

[GitHub] [storm] RuiLi8080 opened a new pull request #3218: [STORM-3591] change log level to debug for scheduling left over sys tasks

RuiLi8080 opened a new pull request #3218: [STORM-3591] change log level to debug for scheduling left over sys tasks
URL: https://github.com/apache/storm/pull/3218
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [storm] Ethanlm commented on a change in pull request #3218: [STORM-3591] change log level to debug for scheduling left over sys tasks

Posted by GitBox <gi...@apache.org>.
Ethanlm commented on a change in pull request #3218: [STORM-3591] change log level to debug for scheduling left over sys tasks
URL: https://github.com/apache/storm/pull/3218#discussion_r384608983
 
 

 ##########
 File path: storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/DefaultResourceAwareStrategy.java
 ##########
 @@ -79,7 +79,8 @@ public SchedulingResult schedule(Cluster cluster, TopologyDetails td) {
         }
 
         executorsNotScheduled.removeAll(scheduledTasks);
-        LOG.debug("/* Scheduling left over task (most likely sys tasks) */");
+        LOG.debug("Scheduling left over tasks {} (most likely sys tasks) from topology {}",
 
 Review comment:
   any idea why this is happening?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [storm] Ethanlm merged pull request #3218: [STORM-3591] change log level to debug for scheduling left over sys tasks

Posted by GitBox <gi...@apache.org>.
Ethanlm merged pull request #3218: [STORM-3591] change log level to debug for scheduling left over sys tasks
URL: https://github.com/apache/storm/pull/3218
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [storm] RuiLi8080 commented on a change in pull request #3218: [STORM-3591] change log level to debug for scheduling left over sys tasks

Posted by GitBox <gi...@apache.org>.
RuiLi8080 commented on a change in pull request #3218: [STORM-3591] change log level to debug for scheduling left over sys tasks
URL: https://github.com/apache/storm/pull/3218#discussion_r384651270
 
 

 ##########
 File path: storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/DefaultResourceAwareStrategy.java
 ##########
 @@ -79,7 +79,8 @@ public SchedulingResult schedule(Cluster cluster, TopologyDetails td) {
         }
 
         executorsNotScheduled.removeAll(scheduledTasks);
-        LOG.debug("/* Scheduling left over task (most likely sys tasks) */");
+        LOG.debug("Scheduling left over tasks {} (most likely sys tasks) from topology {}",
 
 Review comment:
   First round of ordering executors only includes topology components. We need this round to schedule left over system components.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [storm] RuiLi8080 commented on a change in pull request #3218: [STORM-3591] change log level to debug for scheduling left over sys tasks

Posted by GitBox <gi...@apache.org>.
RuiLi8080 commented on a change in pull request #3218: [STORM-3591] change log level to debug for scheduling left over sys tasks
URL: https://github.com/apache/storm/pull/3218#discussion_r384651270
 
 

 ##########
 File path: storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/DefaultResourceAwareStrategy.java
 ##########
 @@ -79,7 +79,8 @@ public SchedulingResult schedule(Cluster cluster, TopologyDetails td) {
         }
 
         executorsNotScheduled.removeAll(scheduledTasks);
-        LOG.debug("/* Scheduling left over task (most likely sys tasks) */");
+        LOG.debug("Scheduling left over tasks {} (most likely sys tasks) from topology {}",
 
 Review comment:
   First round of sorting executors only includes topology components. We need this round to schedule left over system components.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services