You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/06/30 06:49:02 UTC

[GitHub] [druid] kanibs commented on pull request #9764: Enabling Static Imports for Unit Testing DSLs (#331)

kanibs commented on pull request #9764:
URL: https://github.com/apache/druid/pull/9764#issuecomment-651582330


   Hey @suneet-s, Thanks for the suggestions. I have updated the pull request accordingly. Also, as per your suggestion, I have used static import of `assert` and `org.apache.druid.common.config.NullHandling.replaceWithDefault` in a test class called `NullHandlingTest`, to verify that the change is working as expected.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org