You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/10/15 18:58:59 UTC
[GitHub] [netbeans] mbien opened a new pull request, #4793: NBABasedBulkSearch::encode doesn't return on cancel
mbien opened a new pull request, #4793:
URL: https://github.com/apache/netbeans/pull/4793
#4781 found a minor bug where `cancel.get()` was checked but ignored.
The last check is redundant since it is the end of the method.
This might have been a copy and paste bug, since other methods have checks like `if (cancel.get) return null;`. I suppose it was meant to only remove the `null` but leave the `return`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4793: NBABasedBulkSearch::encode doesn't return on cancel
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4793:
URL: https://github.com/apache/netbeans/pull/4793#issuecomment-1290609034
@sdedic thanks for taking a look. I also thought that this was fairly low risk - most likely a copy&paste bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien merged pull request #4793: NBABasedBulkSearch::encode doesn't return on cancel
Posted by GitBox <gi...@apache.org>.
mbien merged PR #4793:
URL: https://github.com/apache/netbeans/pull/4793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists