You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by Pierre-Arnaud Marcelot <pa...@marcelot.net> on 2011/09/02 13:43:01 UTC
Re: svn commit: r1164361 - in /directory/apacheds/trunk: installers-maven-plugin/pom.xml installers/pom.xml
Hi Stefan,
On 2 sept. 2011, at 08:42, seelmann@apache.org wrote:
> Author: seelmann
> Date: Fri Sep 2 06:42:07 2011
> New Revision: 1164361
>
> URL: http://svn.apache.org/viewvc?rev=1164361&view=rev
> Log:
> Bump up to current snapshot version. Seems the maven release process doesn't update those guys.
That's because these two projects are not part of the main build by default.
They are triggered by an 'installers' profile in the pom.xml:
>> <profiles>
>> <profile>
>> <id>installers</id>
>> <modules>
>> <module>installers-maven-plugin</module>
>> <module>installers</module>
>> </modules>
>> </profile>
>> </profiles>
Maybe we should include by default those modules in the main build, *but* then trigger to generation of the installers via the 'installers' profile in the 'installers' module.
WDYT?
Regards,
Pierre-Arnaud
> Modified:
> directory/apacheds/trunk/installers-maven-plugin/pom.xml
> directory/apacheds/trunk/installers/pom.xml
>
> Modified: directory/apacheds/trunk/installers-maven-plugin/pom.xml
> URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/installers-maven-plugin/pom.xml?rev=1164361&r1=1164360&r2=1164361&view=diff
> ==============================================================================
> --- directory/apacheds/trunk/installers-maven-plugin/pom.xml (original)
> +++ directory/apacheds/trunk/installers-maven-plugin/pom.xml Fri Sep 2 06:42:07 2011
> @@ -24,7 +24,7 @@
> <parent>
> <groupId>org.apache.directory.server</groupId>
> <artifactId>apacheds-parent</artifactId>
> - <version>2.0.0-M2-SNAPSHOT</version>
> + <version>2.0.0-M3-SNAPSHOT</version>
> </parent>
>
> <artifactId>apacheds-installers-maven-plugin</artifactId>
>
> Modified: directory/apacheds/trunk/installers/pom.xml
> URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/installers/pom.xml?rev=1164361&r1=1164360&r2=1164361&view=diff
> ==============================================================================
> --- directory/apacheds/trunk/installers/pom.xml (original)
> +++ directory/apacheds/trunk/installers/pom.xml Fri Sep 2 06:42:07 2011
> @@ -22,7 +22,7 @@
> <parent>
> <groupId>org.apache.directory.server</groupId>
> <artifactId>apacheds-parent</artifactId>
> - <version>2.0.0-M2-SNAPSHOT</version>
> + <version>2.0.0-M3-SNAPSHOT</version>
> </parent>
>
> <artifactId>apacheds-installers</artifactId>
>
>
Re: svn commit: r1164361 - in /directory/apacheds/trunk: installers-maven-plugin/pom.xml installers/pom.xml
Posted by Pierre-Arnaud Marcelot <pa...@marcelot.net>.
Done at revision 1165244.
http://svn.apache.org/viewvc?rev=1165244&view=rev
I re-integrated the 'installers-maven-plugin' and 'installers' sub-modules in the default build.
Installers generation is triggered by the use of the 'installers' profile ('-Pinstallers').
This will avoid the pom.xml files of these two sub-modules not to be updated when releasing a new version.
Regards,
Pierre-Arnaud
On 5 sept. 2011, at 09:05, Pierre-Arnaud Marcelot wrote:
> On 2 sept. 2011, at 20:11, Stefan Seelmann wrote:
>
>> On Fri, Sep 2, 2011 at 1:43 PM, Pierre-Arnaud Marcelot <pa...@marcelot.net> wrote:
>>> Hi Stefan,
>>>
>>> On 2 sept. 2011, at 08:42, seelmann@apache.org wrote:
>>>
>>>> Author: seelmann
>>>> Date: Fri Sep 2 06:42:07 2011
>>>> New Revision: 1164361
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=1164361&view=rev
>>>> Log:
>>>> Bump up to current snapshot version. Seems the maven release process doesn't update those guys.
>>>
>>> That's because these two projects are not part of the main build by default.
>>> They are triggered by an 'installers' profile in the pom.xml:
>>>>> <profiles>
>>>>> <profile>
>>>>> <id>installers</id>
>>>>> <modules>
>>>>> <module>installers-maven-plugin</module>
>>>>> <module>installers</module>
>>>>> </modules>
>>>>> </profile>
>>>>> </profiles>
>>
>> Ok, I understand.
>>
>>> Maybe we should include by default those modules in the main build, *but* then trigger to generation of the installers via the 'installers' profile in the 'installers' module.
>>
>> Makes sense but I don't understand the implications yet. Is the
>> 'installers' profile then automatically activated when building the
>> release so that the installers are automatically generated when
>> cutting a release? Or should/must this be done manually?
>
> It would stay the same as it is right now. It won't be generated by default.
>
> I think it's better to keep this a manual task.
> Especially because the release manager may not have all the required utilities (dpkg, rpmbuild, packageMaker, etc.) on his machine.
>
> Regards,
> Pierre-Arnaud
>
>> Kind Regards,
>> Stefan
>
Re: svn commit: r1164361 - in /directory/apacheds/trunk: installers-maven-plugin/pom.xml installers/pom.xml
Posted by Pierre-Arnaud Marcelot <pa...@marcelot.net>.
On 2 sept. 2011, at 20:11, Stefan Seelmann wrote:
> On Fri, Sep 2, 2011 at 1:43 PM, Pierre-Arnaud Marcelot <pa...@marcelot.net> wrote:
>> Hi Stefan,
>>
>> On 2 sept. 2011, at 08:42, seelmann@apache.org wrote:
>>
>>> Author: seelmann
>>> Date: Fri Sep 2 06:42:07 2011
>>> New Revision: 1164361
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1164361&view=rev
>>> Log:
>>> Bump up to current snapshot version. Seems the maven release process doesn't update those guys.
>>
>> That's because these two projects are not part of the main build by default.
>> They are triggered by an 'installers' profile in the pom.xml:
>>>> <profiles>
>>>> <profile>
>>>> <id>installers</id>
>>>> <modules>
>>>> <module>installers-maven-plugin</module>
>>>> <module>installers</module>
>>>> </modules>
>>>> </profile>
>>>> </profiles>
>
> Ok, I understand.
>
>> Maybe we should include by default those modules in the main build, *but* then trigger to generation of the installers via the 'installers' profile in the 'installers' module.
>
> Makes sense but I don't understand the implications yet. Is the
> 'installers' profile then automatically activated when building the
> release so that the installers are automatically generated when
> cutting a release? Or should/must this be done manually?
It would stay the same as it is right now. It won't be generated by default.
I think it's better to keep this a manual task.
Especially because the release manager may not have all the required utilities (dpkg, rpmbuild, packageMaker, etc.) on his machine.
Regards,
Pierre-Arnaud
> Kind Regards,
> Stefan
Re: svn commit: r1164361 - in /directory/apacheds/trunk:
installers-maven-plugin/pom.xml installers/pom.xml
Posted by Stefan Seelmann <se...@apache.org>.
On Fri, Sep 2, 2011 at 1:43 PM, Pierre-Arnaud Marcelot <pa...@marcelot.net> wrote:
> Hi Stefan,
>
> On 2 sept. 2011, at 08:42, seelmann@apache.org wrote:
>
>> Author: seelmann
>> Date: Fri Sep 2 06:42:07 2011
>> New Revision: 1164361
>>
>> URL: http://svn.apache.org/viewvc?rev=1164361&view=rev
>> Log:
>> Bump up to current snapshot version. Seems the maven release process doesn't update those guys.
>
> That's because these two projects are not part of the main build by default.
> They are triggered by an 'installers' profile in the pom.xml:
>>> <profiles>
>>> <profile>
>>> <id>installers</id>
>>> <modules>
>>> <module>installers-maven-plugin</module>
>>> <module>installers</module>
>>> </modules>
>>> </profile>
>>> </profiles>
Ok, I understand.
> Maybe we should include by default those modules in the main build, *but* then trigger to generation of the installers via the 'installers' profile in the 'installers' module.
Makes sense but I don't understand the implications yet. Is the
'installers' profile then automatically activated when building the
release so that the installers are automatically generated when
cutting a release? Or should/must this be done manually?
Kind Regards,
Stefan