You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/19 15:11:13 UTC

[GitHub] [arrow-datafusion] AssHero commented on a diff in pull request #2721: Add additional data types are supported in hash join

AssHero commented on code in PR #2721:
URL: https://github.com/apache/arrow-datafusion/pull/2721#discussion_r901120957


##########
datafusion/core/src/physical_plan/hash_join.rs:
##########
@@ -1054,6 +1079,102 @@ fn equal_rows(
             DataType::LargeUtf8 => {
                 equal_rows_elem!(LargeStringArray, l, r, left, right, null_equals_null)
             }
+            DataType::Decimal(_, _) => {

Review Comment:
   I think the scale should be the same, precision is insignificant. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org