[GitHub] [flink] pnowojski commented on issue #8826: [FLINK-12479][operators] Integrate StreamInputProcessor(s) with mailbox

[GitBox <gi...@apache.org>]

pnowojski commented on issue #8826: [FLINK-12479][operators] Integrate StreamInputProcessor(s) with mailbox
URL: https://github.com/apache/flink/pull/8826#issuecomment-505434897
 
 
   > Suggestion: you can rename old StreamInputProcessor to StreamOneInputProcessor first, in a separate commit. And introduce a StreamInputProcessor interface as follow up commit. This way it should preserve git history of the newly named StreamOneInputProcessor.
   
   I didn't know that it can work like that. Will do :)
   
   > Question: do I get it right that StreamTwoInputProcessor.processInput is still blocking, namely in barrierHandler.isAvailable().get()?
   
   ops. Missed that. I'm not sure if it's worth adding some tests for that, it might be an overkill, especially that this will get a pretty good test coverage once we merge in progress/pending mailbox PRs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services