You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/12/19 19:31:42 UTC

[GitHub] [hive] viirya commented on a change in pull request #1794: [DO-NOT-MERGE] Test exclude calcite in beeline

viirya commented on a change in pull request #1794:
URL: https://github.com/apache/hive/pull/1794#discussion_r546274190



##########
File path: beeline/pom.xml
##########
@@ -99,6 +99,20 @@
       <version>${project.version}</version>
       <classifier>tests</classifier>
       <scope>test</scope>
+      <exclusions>

Review comment:
       For test scope, I think the test-jar won't include shaded dependencies. Then un-shaded dependencies will be pull. So I think we need to exclude them.
   
   If there are other places using hive-exec in test scope, I think they might also need to exclude these.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org