You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/08/04 03:01:57 UTC
[GitHub] [incubator-mxnet] wkcn opened a new pull request #18857: set upper bound infinity for conv, resize, upsampling, etc.
wkcn opened a new pull request #18857:
URL: https://github.com/apache/incubator-mxnet/pull/18857
## Description ##
Hi there,
there is a limitation for the unnecessary upper bound of some arguments in some operators.
```
raise get_last_ffi_error()
mxnet.base.MXNetError: MXNetError: value 147456 for Parameter num_filter exceed bound [1,100000]
num_filter: Convolution filter(channel) number, in operator Convolution(name="", __profiler_scope__="resnetv10:stage2:conv5:", no_bias="True", num_filter="147456", pad="(0, 0)", layout="NCHW", dilate="(1, 1)", num_group="256", stride="(1, 1)", kernel="(1, 1)")
```
I remove the upper bound in this PR.
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage:
- Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
- Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
- Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
- [ ] Code is well-documented:
- For user-facing API changes, API doc string has been updated.
- For new C++ functions in header files, their functionalities and arguments are documented.
- For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
- Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
- [ ] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
### Changes ###
- [ ] Feature1, tests, (and when applicable, API doc)
- [ ] Feature2, tests, (and when applicable, API doc)
## Comments ##
- If this change is a backward incompatible change, why must this change be made.
- Interesting edge cases to note here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18857: set upper bound infinity for conv, resize, upsampling, etc.
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18857:
URL: https://github.com/apache/incubator-mxnet/pull/18857#issuecomment-668384964
Undefined action detected.
Permissible actions are : run ci [all], run ci [job1, job2]
Example : @mxnet-bot run ci [all]
Example : @mxnet-bot run ci [centos-cpu, clang]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] wkcn commented on pull request #18857: [Fix Bug] set upper bound infinity for conv, resize, upsampling, etc.
Posted by GitBox <gi...@apache.org>.
wkcn commented on pull request #18857:
URL: https://github.com/apache/incubator-mxnet/pull/18857#issuecomment-669785155
@mxnet-bot run ci [unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] wkcn commented on pull request #18857: set upper bound infinity for conv, resize, upsampling, etc.
Posted by GitBox <gi...@apache.org>.
wkcn commented on pull request #18857:
URL: https://github.com/apache/incubator-mxnet/pull/18857#issuecomment-668384957
@mxnet-bot run ci windows-cpu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha merged pull request #18857: [Fix Bug] set upper bound infinity for conv, resize, upsampling, etc.
Posted by GitBox <gi...@apache.org>.
szha merged pull request #18857:
URL: https://github.com/apache/incubator-mxnet/pull/18857
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot removed a comment on pull request #18857: set upper bound infinity for conv, resize, upsampling, etc.
Posted by GitBox <gi...@apache.org>.
mxnet-bot removed a comment on pull request #18857:
URL: https://github.com/apache/incubator-mxnet/pull/18857#issuecomment-668384964
Undefined action detected.
Permissible actions are : run ci [all], run ci [job1, job2]
Example : @mxnet-bot run ci [all]
Example : @mxnet-bot run ci [centos-cpu, clang]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18857: [Fix Bug] set upper bound infinity for conv, resize, upsampling, etc.
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18857:
URL: https://github.com/apache/incubator-mxnet/pull/18857#issuecomment-671671350
Jenkins CI successfully triggered : [unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] wkcn edited a comment on pull request #18857: set upper bound infinity for conv, resize, upsampling, etc.
Posted by GitBox <gi...@apache.org>.
wkcn edited a comment on pull request #18857:
URL: https://github.com/apache/incubator-mxnet/pull/18857#issuecomment-668384957
@mxnet-bot run ci [windows-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18857: set upper bound infinity for conv, resize, upsampling, etc.
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18857:
URL: https://github.com/apache/incubator-mxnet/pull/18857#issuecomment-668384781
Undefined action detected.
Permissible actions are : run ci [all], run ci [job1, job2]
Example : @mxnet-bot run ci [all]
Example : @mxnet-bot run ci [centos-cpu, clang]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] wkcn commented on pull request #18857: set upper bound infinity for conv, resize, upsampling, etc.
Posted by GitBox <gi...@apache.org>.
wkcn commented on pull request #18857:
URL: https://github.com/apache/incubator-mxnet/pull/18857#issuecomment-668384753
@mxnet-bot run ci windows-cpu
```
test_sparse_storage_fallback
2020-08-04T04:15:59.290Z] > raise AssertionError(msg)
[2020-08-04T04:15:59.290Z] E AssertionError:
[2020-08-04T04:15:59.290Z] E Items are not equal:
[2020-08-04T04:15:59.290Z] E Error 1.214443 exceeds tolerance rtol=1.000000e-04, atol=1.000000e-03 (mismatch at least 13.750000%).
[2020-08-04T04:15:59.290Z] E Location of maximum error: (0, 0), NUMERICAL_x=0.92187500, BACKWARD_x=0.92320156
[2020-08-04T04:15:59.290Z] E ACTUAL: array([[0.921875, 0.921875, 0.921875, ..., 0.921875, 0.921875, 0.921875],
[2020-08-04T04:15:59.290Z] E [0.921875, 0.921875, 0.921875, ..., 0.921875, 0.921875, 0.921875],
[2020-08-04T04:15:59.290Z] E [0.921875, 0.921875, 0.921875, ..., 0.921875, 0.921875, 0.921875],...
[2020-08-04T04:15:59.290Z] E DESIRED: array([[0.92320156, 0.92320156, 0.92320156, ..., 0.92320156, 0.92320156,
[2020-08-04T04:15:59.290Z] E 0.92320156],
[2020-08-04T04:15:59.290Z] E [0.92320156, 0.92320156, 0.92320156, ..., 0.92320156, 0.92320156,...
[2020-08-04T04:15:59.290Z]
[2020-08-04T04:15:59.290Z] windows_package\python\mxnet\test_utils.py:735: AssertionError
[2020-08-04T04:15:59.290Z] ---------------------------- Captured stderr setup ----------------------------
[2020-08-04T04:15:59.290Z] DEBUG:root:np/mx/python random seeds are set to 1153784093, use MXNET_TEST_SEED=1153784093 to
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot removed a comment on pull request #18857: set upper bound infinity for conv, resize, upsampling, etc.
Posted by GitBox <gi...@apache.org>.
mxnet-bot removed a comment on pull request #18857:
URL: https://github.com/apache/incubator-mxnet/pull/18857#issuecomment-668384781
Undefined action detected.
Permissible actions are : run ci [all], run ci [job1, job2]
Example : @mxnet-bot run ci [all]
Example : @mxnet-bot run ci [centos-cpu, clang]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18857: set upper bound infinity for conv, resize, upsampling, etc.
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18857:
URL: https://github.com/apache/incubator-mxnet/pull/18857#issuecomment-668385078
Jenkins CI successfully triggered : [windows-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18857: set upper bound infinity for conv, resize, upsampling, etc.
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18857:
URL: https://github.com/apache/incubator-mxnet/pull/18857#issuecomment-668352535
Hey @wkcn , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [sanity, clang, windows-cpu, edge, miscellaneous, website, centos-cpu, unix-gpu, windows-gpu, unix-cpu, centos-gpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18857: [Fix Bug] set upper bound infinity for conv, resize, upsampling, etc.
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18857:
URL: https://github.com/apache/incubator-mxnet/pull/18857#issuecomment-669785184
Jenkins CI successfully triggered : [unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] wkcn commented on pull request #18857: [Fix Bug] set upper bound infinity for conv, resize, upsampling, etc.
Posted by GitBox <gi...@apache.org>.
wkcn commented on pull request #18857:
URL: https://github.com/apache/incubator-mxnet/pull/18857#issuecomment-671671325
@mxnet-bot run ci [unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org