You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "mapleFU (via GitHub)" <gi...@apache.org> on 2023/02/02 08:47:51 UTC
[GitHub] [arrow] mapleFU opened a new pull request, #33996: MINOR: [C++][Parquet] Parquet Statistics fix some comments and style
mapleFU opened a new pull request, #33996:
URL: https://github.com/apache/arrow/pull/33996
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Statistics uses some virtual functions in constructor, so here I change it to explicit call rather than implicit virtual fn call. And I also fixed some comments typo
### What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
Some code style and comment fix in parquet statistics
### Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
No, and no tests are need.
### Are there any user-facing changes?
no
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on pull request #33996: MINOR: [C++][Parquet] Fix some comments and style in Statistics
Posted by "emkornfield (via GitHub)" <gi...@apache.org>.
emkornfield commented on PR #33996:
URL: https://github.com/apache/arrow/pull/33996#issuecomment-1427445248
Apologies, seems OK to me, not clear exactly why we prefer full references to the static methods?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #33996: MINOR: [C++][Parquet] Fix some comments and style in Statistics
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #33996:
URL: https://github.com/apache/arrow/pull/33996#issuecomment-1423211156
['Python', 'R'] benchmarks have high level of regressions.
[test-mac-arm](https://conbench.ursa.dev/compare/runs/4550260c557b4719b00fd4dc3972387a...0f5c13c2cceb4fc79c3023966fe1ab78/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mapleFU commented on pull request #33996: MINOR: [C++][Parquet] Fix some comments and style in Statistics
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #33996:
URL: https://github.com/apache/arrow/pull/33996#issuecomment-1422333071
@pitrou @wjones127 Mind take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mapleFU commented on pull request #33996: MINOR: [C++][Parquet] Fix some comments and style in Statistics
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #33996:
URL: https://github.com/apache/arrow/pull/33996#issuecomment-1427462685
> Apologies, seems OK to me, not clear exactly why we prefer full references to the static methods?
Personally it's confusing. Calling "virtual" method in dtor and ctor is not virtual. But user is easy to take it as virtual.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mapleFU commented on pull request #33996: MINOR: [C++][Parquet] Parquet Statistics fix some comments and style
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #33996:
URL: https://github.com/apache/arrow/pull/33996#issuecomment-1413496989
@pitrou Mind take a look? This patch is small and didn't change any impl logics...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wgtmac commented on pull request #33996: MINOR: [C++][Parquet] Fix some comments and style in Statistics
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #33996:
URL: https://github.com/apache/arrow/pull/33996#issuecomment-1413896612
> @wgtmac @emkornfield Would you like to comment on this? The changes look fine to me on the principle.
Looking good on my side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #33996: MINOR: [C++][Parquet] Fix some comments and style in Statistics
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #33996:
URL: https://github.com/apache/arrow/pull/33996#issuecomment-1423208347
Benchmark runs are scheduled for baseline = 39bad5442c6447bf07594b09e4b29118b3211460 and contender = 3e7b7e0b6d655ab405d23fcf3e8f1d60eedf95ab. 3e7b7e0b6d655ab405d23fcf3e8f1d60eedf95ab is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/150aa9ef5d7945969ae992309a845bd0...8056102ad3784f5393ce246d4242dacf/)
[Failed :arrow_down:0.83% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/4550260c557b4719b00fd4dc3972387a...0f5c13c2cceb4fc79c3023966fe1ab78/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/3dee5dfdb23f4a17a97a4f03a607887a...d637078b41084424965850b2fb6ff7f5/)
[Finished :arrow_down:0.16% :arrow_up:0.03%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/55ef4e4c61f44e6b825c36c26d303b8a...b0f5f1be9ecf408c88829da7b2e41328/)
Buildkite builds:
[Failed] [`3e7b7e0b` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2346)
[Failed] [`3e7b7e0b` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2374)
[Failed] [`3e7b7e0b` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2344)
[Finished] [`3e7b7e0b` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2365)
[Failed] [`39bad544` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2345)
[Failed] [`39bad544` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2373)
[Failed] [`39bad544` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2343)
[Finished] [`39bad544` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2364)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wjones127 merged pull request #33996: MINOR: [C++][Parquet] Fix some comments and style in Statistics
Posted by "wjones127 (via GitHub)" <gi...@apache.org>.
wjones127 merged PR #33996:
URL: https://github.com/apache/arrow/pull/33996
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #33996: MINOR: [C++][Parquet] Fix some comments and style in Statistics
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #33996:
URL: https://github.com/apache/arrow/pull/33996#issuecomment-1413893223
@wgtmac @emkornfield Would you like to comment on this? The changes look fine on the principle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org