[GitHub] [beam] vachan-shetty commented on a diff in pull request #21739: Fix for increased FAILED_PRECONDITION errors in BQ Read API.

[GitBox <gi...@apache.org>]

vachan-shetty commented on code in PR #21739:
URL: https://github.com/apache/beam/pull/21739#discussion_r891741954


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryStorageStreamSource.java:
##########
@@ -355,6 +356,7 @@ public synchronized BigQueryStorageStreamSource<T> getCurrentSource() {
                       .build(),
                   source.readSession.getTable());
           newResponseIterator = newResponseStream.iterator();
+          newResponseIterator.hasNext();

Review Comment:
   Added a comment.
   
   I don't think this indicates an issue with the API per se. We could probably try and read from the stream more explicitly in case that is clearer but the comment also points out why this important now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org