You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by stevengill <gi...@git.apache.org> on 2016/02/12 02:52:03 UTC
[GitHub] cordova-docs pull request: Renamed 6.0.0 to 6.x
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-docs/pull/499
Renamed 6.0.0 to 6.x
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-docs V6
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-docs/pull/499.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #499
----
commit 740e12c6aa43d84d8ef7148d4f33d64cfef456b7
Author: Steve Gill <st...@gmail.com>
Date: 2016-02-04T19:19:35Z
added version 6.x, removed version 6.0.0
commit ebf9db69910a19773301f4cd7c544075468a4046
Author: Steve Gill <st...@gmail.com>
Date: 2016-02-04T19:20:07Z
added 6.0.0 redirect to 6.x, updated incrementversion.js
commit 12f02fcf48755855b7872f0e640ea713ddac23b4
Author: Steve Gill <st...@gmail.com>
Date: 2016-02-12T01:45:37Z
deleted zh 6-0-0 manual toc
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Renamed 6.0.0 to 6.x
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/499#issuecomment-195681406
@stevengill please close this PR when you have a moment. :) The changes have been applied.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Renamed 6.0.0 to 6.x
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/499#discussion_r52703206
--- Diff: tools/bin/incrementversion.js ---
@@ -36,9 +36,11 @@ function isValidVersion(version) {
if (version == DEV_VERSION_NAME) {
return false;
}
+ /*
if (!semver.valid(version)) {
--- End diff --
Please add a `validVersion` function here, just with some simpler logic. A test `\d\.x` should probably be fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Renamed 6.0.0 to 6.x
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/499#discussion_r52703243
--- Diff: www/.htaccess ---
@@ -41,6 +41,9 @@ RewriteRule ^.*docs/(\w\w)/latest$ {{site.baseurl}}/docs/$1/latest/ [R=302,L]
# resource, but the browser won't change the URI (no redirects followed).
RewriteRule ^.*docs/(\w\w)/latest/(.*)$ {{site.baseurl}}/docs/$1/{{site.latest_docs_version}}/$2 [L]
+# rewrite 6.0.0 links to point to 6.x links
+RewriteRule ^.*docs/(\w\w)/6.0.0/(.*)$ {{site.baseurl}}/docs/$1/6.x/$2 [L]
--- End diff --
Please make this a 301 redirect.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Renamed 6.0.0 to 6.x
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/499#discussion_r52703124
--- Diff: www/_data/toc/zh-6-x-manual.yml ---
@@ -0,0 +1,19 @@
+- {name: "\u8F14\u52A9\u7DDA", url: !!python/unicode '/docs/zh/6.x/'}
+- {name: "\u6982\u8FF0", url: !!python/unicode '/docs/zh/6.x/guide/overview/index.html'}
+- {name: "\u5E73\u81FA\u652F\u63F4", url: !!python/unicode '/docs/zh/6.x/guide/support/index.html'}
+- {name: "\u547D\u4EE4\u5217\u4ECB\u9762", url: !!python/unicode '/docs/zh/6.x/guide/cli/index.html'}
+- {name: "\u5E73\u81FA\u6307\u5357", url: !!python/unicode '/docs/zh/6.x/guide/platforms/index.html'}
+- {name: "\u4F7F\u7528 Plugman \u4F86\u7BA1\u7406\u5916\u639B\u7A0B\u5F0F", url: !!python/unicode '/docs/zh/6.x/plugin_ref/plugman.html'}
+- {name: "Config.xml \u6A94", url: !!python/unicode '/docs/zh/6.x/config_ref/index.html'}
+- {name: "\u5716\u793A\u548C\u555F\u52D5\u756B\u9762", url: !!python/unicode '/docs/zh/6.x/config_ref/images.html'}
+- {name: "\u5D4C\u5165 WebViews", url: !!python/unicode '/docs/zh/6.x/guide/hybrid/webviews/index.html'}
+- {name: "\u5916\u639B\u7A0B\u5F0F\u958B\u767C\u6307\u5357", url: !!python/unicode '/docs/zh/6.x/guide/hybrid/plugins/index.html'}
+- {name: "\u5916\u639B\u7A0B\u5F0F\u898F\u7BC4", url: !!python/unicode '/docs/zh/6.x/plugin_ref/spec.html'}
+- {name: "\u96B1\u79C1\u6307\u5357", url: !!python/unicode '/docs/zh/6.x/guide/appdev/privacy/index.html'}
+- {name: "\u5B89\u5168\u6307\u5357", url: !!python/unicode '/docs/zh/6.x/guide/appdev/security/index.html'}
+- {name: "\u5E73\u81FA\u548C\u5916\u639B\u7A0B\u5F0F\u7248\u672C\u7BA1\u7406", url: !!python/unicode '/docs/zh/6.x/platform_plugin_versioning_ref/index.html'}
+- {name: "\u767D\u540D\u55AE\u6307\u5357", url: !!python/unicode '/docs/zh/6.x/guide/appdev/whitelist/index.html'}
+- {name: "\u5B58\u5132", url: !!python/unicode '/docs/zh/6.x/cordova/storage/storage.html'}
+- {name: "\u4E8B\u4EF6", url: !!python/unicode '/docs/zh/6.x/cordova/events/events.html'}
+- {name: "\u5916\u639B\u7A0B\u5F0F\u7684 Api", url: !!python/unicode '/docs/zh/6.x/cordova/plugins/pluginapis.html'}
+- {name: "\u95DC\u9375\u5B57\u7D22\u5F15", url: !!python/unicode '/docs/zh/6.x/page_index.html'}
--- End diff --
This change should only be a rename: there are no `/docs/XX/YYY/` prefixes in the ToC files anymore.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Renamed 6.0.0 to 6.x
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill closed the pull request at:
https://github.com/apache/cordova-docs/pull/499
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Renamed 6.0.0 to 6.x
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/499#issuecomment-188586378
@stevengill you can close this PR. I've done the work in #520 and I'll merge it tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Renamed 6.0.0 to 6.x
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/499#discussion_r52703222
--- Diff: tools/bin/incrementversion.js ---
@@ -71,10 +73,10 @@ function main () {
}
// only create greater versions
- if (!semver.gt(newVersion, oldVersion)) {
+ /*if (!semver.gt(newVersion, oldVersion)) {
--- End diff --
Please make this a simple function: something like just a check for greater major version number.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Renamed 6.0.0 to 6.x
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-docs/pull/499#issuecomment-183146630
Still need to finish incorporating feedback from #484
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org