You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Antonio Petrelli (JIRA)" <ji...@apache.org> on 2006/10/17 09:54:25 UTC
[jira] Commented: (SB-44) TilesContextFactory should be a regular
class
[ http://issues.apache.org/struts/browse/SB-44?page=comments#action_38418 ]
Antonio Petrelli commented on SB-44:
------------------------------------
David
Can you export your patch again? It seems that it contains also code committed in SB-28.
Thank you
> TilesContextFactory should be a regular class
> ---------------------------------------------
>
> Key: SB-44
> URL: http://issues.apache.org/struts/browse/SB-44
> Project: Sandbox
> Issue Type: Improvement
> Components: Tiles
> Affects Versions: 2.0
> Environment: None
> Reporter: Antonio Petrelli
> Attachments: tiles-context-factory.patch
>
>
> The org.apache.tiles.context.TilesContextFactory class should be a regular class, not a class with only static methods.
> This is because this object could eventually be replaced with another one specified by the developer that uses Tiles, i.e. enhancing configuration. Moreover, a class with only static methods should be only an "utility class", thing that TilesContextFactory is not.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[tiles2] Re: [jira] Commented: (SB-44) TilesContextFactory should
be a regular class
Posted by "David H. DeWolf" <dd...@apache.org>.
Hmm. . . I'll look into it. . .sorry about that.
Antonio Petrelli (JIRA) wrote:
> [ http://issues.apache.org/struts/browse/SB-44?page=comments#action_38418 ]
>
> Antonio Petrelli commented on SB-44:
> ------------------------------------
>
> David
> Can you export your patch again? It seems that it contains also code committed in SB-28.
> Thank you
>
>> TilesContextFactory should be a regular class
>> ---------------------------------------------
>>
>> Key: SB-44
>> URL: http://issues.apache.org/struts/browse/SB-44
>> Project: Sandbox
>> Issue Type: Improvement
>> Components: Tiles
>> Affects Versions: 2.0
>> Environment: None
>> Reporter: Antonio Petrelli
>> Attachments: tiles-context-factory.patch
>>
>>
>> The org.apache.tiles.context.TilesContextFactory class should be a regular class, not a class with only static methods.
>> This is because this object could eventually be replaced with another one specified by the developer that uses Tiles, i.e. enhancing configuration. Moreover, a class with only static methods should be only an "utility class", thing that TilesContextFactory is not.
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org