You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "coderzc (via GitHub)" <gi...@apache.org> on 2023/08/28 15:14:44 UTC
[GitHub] [pulsar] coderzc opened a new pull request, #21081: [fix][broker] Fix write duplicate entries into the compacted ledger after RawReader reconnects
coderzc opened a new pull request, #21081:
URL: https://github.com/apache/pulsar/pull/21081
### Motivation
Currently, the compactor will write duplicate entries into the compacted ledger after RawReader reconnects on phase two.
### Modifications
If the messageId read is less than or equal to lastCompactedMessageId then the entry is skipped.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE -->
<!--
After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- closed pull request #21081: [fix][broker] Fix write duplicate entries into the compacted ledger after RawReader reconnects
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- closed pull request #21081: [fix][broker] Fix write duplicate entries into the compacted ledger after RawReader reconnects
URL: https://github.com/apache/pulsar/pull/21081
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a diff in pull request #21081: [fix][broker] Fix write duplicate entries into the compacted ledger after RawReader reconnects
Posted by "codelipenghui (via GitHub)" <gi...@apache.org>.
codelipenghui commented on code in PR #21081:
URL: https://github.com/apache/pulsar/pull/21081#discussion_r1312937794
##########
pulsar-broker/src/test/java/org/apache/pulsar/compaction/CompactionTest.java:
##########
@@ -1926,4 +1926,69 @@ public void testDispatcherMaxReadSizeBytes() throws Exception {
consumer.close();
producer.close();
}
+
+ @Test
+ public void testCompactionDuplicate() throws Exception {
+ String topic = "persistent://my-property/use/my-ns/testCompactionDuplicate";
+ final int numMessages = 1000;
+ final int maxKeys = 800;
+
+ @Cleanup
+ Producer<byte[]> producer = pulsarClient.newProducer()
+ .topic(topic)
+ .enableBatching(false)
+ .messageRoutingMode(MessageRoutingMode.SinglePartition)
+ .create();
+
+ // trigger compaction (create __compaction cursor)
+ admin.topics().triggerCompaction(topic);
+
+ Map<String, byte[]> expected = new HashMap<>();
+ Random r = new Random(0);
+
+ pulsarClient.newConsumer().topic(topic).subscriptionName("sub1").readCompacted(true).subscribe().close();
+
+ for (int j = 0; j < numMessages; j++) {
+ int keyIndex = r.nextInt(maxKeys);
+ String key = "key" + keyIndex;
+ byte[] data = ("my-message-" + key + "-" + j).getBytes();
+ producer.newMessage().key(key).value(data).send();
+ expected.put(key, data);
+ }
+
+ producer.flush();
+
+ // trigger compaction
+ admin.topics().triggerCompaction(topic);
+
+ Awaitility.await().untilAsserted(() -> {
+ assertEquals(admin.topics().compactionStatus(topic).status,
+ LongRunningProcessStatus.Status.RUNNING);
+ });
+
+ // Wait for phase one to complete
+ Thread.sleep(500);
+
+ admin.topics().unload(topic);
+
+ Awaitility.await().untilAsserted(() -> {
+ PersistentTopicInternalStats internalStats = admin.topics().getInternalStats(topic, false);
+ // Compacted topic ledger should have same number of entry equals to number of unique key.
+ Assert.assertEquals(expected.size(), internalStats.compactedLedger.entries);
Review Comment:
```suggestion
Assert.assertEquals(internalStats.compactedLedger.entries, expected.size());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on a diff in pull request #21081: [fix][broker] Fix write duplicate entries into the compacted ledger after RawReader reconnects
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- commented on code in PR #21081:
URL: https://github.com/apache/pulsar/pull/21081#discussion_r1309543104
##########
pulsar-broker/src/test/java/org/apache/pulsar/compaction/CompactionTest.java:
##########
@@ -1877,4 +1877,68 @@ public void testReceiverQueueSize() throws Exception {
consumer.close();
producer.close();
}
+
+ @Test
+ public void testCompactionDuplicate() throws Exception {
+ String topic = "persistent://my-property/use/my-ns/testCompactionDuplicate";
+ final int numMessages = 1000;
+ final int maxKeys = 800;
+
+ Producer<byte[]> producer = pulsarClient.newProducer()
+ .topic(topic)
+ .enableBatching(false)
+ .messageRoutingMode(MessageRoutingMode.SinglePartition)
+ .create();
Review Comment:
Close the `producer`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- merged pull request #21081: [fix][broker] Fix write duplicate entries into the compacted ledger after RawReader reconnects
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- merged PR #21081:
URL: https://github.com/apache/pulsar/pull/21081
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org