You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "Goldstein Lyor (JIRA)" <ji...@apache.org> on 2015/11/22 07:20:11 UTC
[jira] [Resolved] (SSHD-584) Check keys and configuration files
permissions as closely as possible like OpenSSH by default
[ https://issues.apache.org/jira/browse/SSHD-584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Goldstein Lyor resolved SSHD-584.
---------------------------------
Resolution: Fixed
Fix Version/s: 1.1.0
Can close the pull request we used for the code review
> Check keys and configuration files permissions as closely as possible like OpenSSH by default
> ---------------------------------------------------------------------------------------------
>
> Key: SSHD-584
> URL: https://issues.apache.org/jira/browse/SSHD-584
> Project: MINA SSHD
> Issue Type: Bug
> Affects Versions: 1.1.0
> Environment: build
> Reporter: Alon Bar-Lev
> Fix For: 1.1.0
>
>
> Got this exception:
> ---
> testAttributes(org.apache.sshd.client.subsystem.sftp.SftpFileSystemTest) Time elapsed: 5.581 sec <<< ERROR!
> java.io.IOException: String permission violation (GROUP_READ) for /home/alonbl/.ssh/config
> at org.apache.sshd.client.config.hosts.DefaultConfigFileHostEntryResolver.reloadHostConfigEntries(DefaultConfigFileHostEntryResolver.java:80)
> at org.apache.sshd.client.config.hosts.ConfigFileHostEntryResolver.resolveEffectiveResolver(ConfigFileHostEntryResolver.java:86)
> at org.apache.sshd.client.config.hosts.ConfigFileHostEntryResolver.resolveEffectiveHost(ConfigFileHostEntryResolver.java:59)
> at org.apache.sshd.client.SshClient.connect(SshClient.java:339)
> at org.apache.sshd.client.subsystem.sftp.SftpFileSystemProvider.newFileSystem(SftpFileSystemProvider.java:177)
> at org.apache.sshd.client.subsystem.sftp.SftpFileSystemProvider.newFileSystem(SftpFileSystemProvider.java:87)
> at java.nio.file.FileSystems.newFileSystem(FileSystems.java:322)
> at java.nio.file.FileSystems.newFileSystem(FileSystems.java:272)
> at org.apache.sshd.client.subsystem.sftp.SftpFileSystemTest.testAttributes(SftpFileSystemTest.java:136)
> ---
> While ssh code enforces only world/group writeable at readconf.c::read_config_file:
> ---
> if (flags & SSHCONF_CHECKPERM) {
> struct stat sb;
> if (fstat(fileno(f), &sb) == -1)
> fatal("fstat %s: %s", filename, strerror(errno));
> if (((sb.st_uid != 0 && sb.st_uid != getuid()) ||
> (sb.st_mode & 022) != 0))
> fatal("Bad owner or permissions on %s", filename);
> }
> ---
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)