You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/23 06:35:19 UTC
[GitHub] [spark] MaxGekk opened a new pull request #29845: [SPARK-32306][SQL][DOCS][3.0] Clarify the result of `percentile_approx()`
MaxGekk opened a new pull request #29845:
URL: https://github.com/apache/spark/pull/29845
### What changes were proposed in this pull request?
More precise description of the result of the `percentile_approx()` function and its synonym `approx_percentile()`. The proposed sentence clarifies that the function returns **one of elements** (or array of elements) from the input column.
### Why are the changes needed?
To improve Spark docs and avoid misunderstanding of the function behavior.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
`./dev/scalastyle`
Authored-by: Max Gekk <ma...@gmail.com>
Signed-off-by: Liang-Chi Hsieh <vi...@gmail.com>
(cherry picked from commit 7c14f177eb5b52d491f41b217926cc8ca5f0ce4c)
Signed-off-by: Max Gekk <ma...@gmail.com>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29845: [SPARK-32306][SQL][DOCS][3.0] Clarify the result of `percentile_approx()`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29845:
URL: https://github.com/apache/spark/pull/29845#issuecomment-697176311
**[Test build #129009 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129009/testReport)** for PR 29845 at commit [`d1bacac`](https://github.com/apache/spark/commit/d1bacac869cad4fa6cf919996b8bbacf8ca84053).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29845: [SPARK-32306][SQL][DOCS][3.0] Clarify the result of `percentile_approx()`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29845:
URL: https://github.com/apache/spark/pull/29845#issuecomment-697176457
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29845: [SPARK-32306][SQL][DOCS][3.0] Clarify the result of `percentile_approx()`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29845:
URL: https://github.com/apache/spark/pull/29845#issuecomment-697166958
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29845: [SPARK-32306][SQL][DOCS][3.0] Clarify the result of `percentile_approx()`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29845:
URL: https://github.com/apache/spark/pull/29845#issuecomment-697176469
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129009/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29845: [SPARK-32306][SQL][DOCS][3.0] Clarify the result of `percentile_approx()`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29845:
URL: https://github.com/apache/spark/pull/29845#issuecomment-697176457
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29845: [SPARK-32306][SQL][DOCS][3.0] Clarify the result of `percentile_approx()`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29845:
URL: https://github.com/apache/spark/pull/29845#issuecomment-697166958
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29845: [SPARK-32306][SQL][DOCS][3.0] Clarify the result of `percentile_approx()`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29845:
URL: https://github.com/apache/spark/pull/29845#issuecomment-697166492
**[Test build #129009 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129009/testReport)** for PR 29845 at commit [`d1bacac`](https://github.com/apache/spark/commit/d1bacac869cad4fa6cf919996b8bbacf8ca84053).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29845: [SPARK-32306][SQL][DOCS][3.0] Clarify the result of `percentile_approx()`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29845:
URL: https://github.com/apache/spark/pull/29845#issuecomment-697166492
**[Test build #129009 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129009/testReport)** for PR 29845 at commit [`d1bacac`](https://github.com/apache/spark/commit/d1bacac869cad4fa6cf919996b8bbacf8ca84053).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29845: [SPARK-32306][SQL][DOCS][3.0] Clarify the result of `percentile_approx()`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29845:
URL: https://github.com/apache/spark/pull/29845#issuecomment-697297744
Merged to branch-3.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #29845: [SPARK-32306][SQL][DOCS][3.0] Clarify the result of `percentile_approx()`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #29845:
URL: https://github.com/apache/spark/pull/29845
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org