You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by Aitozi <gi...@git.apache.org> on 2018/06/02 12:43:56 UTC

[GitHub] flink pull request #6059: [Flink-9418] Migrate SharedBuffer to use MapState

Github user Aitozi commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6059#discussion_r192558813
  
    --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/sharedbuffer/EventWrapper.java ---
    @@ -0,0 +1,188 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.cep.nfa.sharedbuffer;
    +
    +import org.apache.flink.api.common.typeutils.CompatibilityResult;
    +import org.apache.flink.api.common.typeutils.TypeDeserializerAdapter;
    +import org.apache.flink.api.common.typeutils.TypeSerializer;
    +import org.apache.flink.api.common.typeutils.TypeSerializerConfigSnapshot;
    +import org.apache.flink.api.common.typeutils.base.IntSerializer;
    +import org.apache.flink.core.memory.DataInputView;
    +import org.apache.flink.core.memory.DataOutputView;
    +
    +import java.io.IOException;
    +import java.util.Objects;
    +
    +/**
    + * Thin wrapper around user event that adds a lock.
    + *
    + * @param <E> user event type
    + */
    +public class EventWrapper<E> {
    --- End diff --
    
    Why the this class use the same name with the inner class in NFA.java? Is this intend to?  It is a little confused


---