You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by mm...@apache.org on 2022/07/09 20:16:13 UTC

[pulsar] branch master updated: [cleanup][client-tests] Fixed various compiler warnings (#16474)

This is an automated email from the ASF dual-hosted git repository.

mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/master by this push:
     new b68415a89dc [cleanup][client-tests] Fixed various compiler warnings (#16474)
b68415a89dc is described below

commit b68415a89dcd067511d01956447d1a507865534c
Author: Dave Maughan <da...@streamnative.io>
AuthorDate: Sat Jul 9 21:16:03 2022 +0100

    [cleanup][client-tests] Fixed various compiler warnings (#16474)
    
    ### Motivation
    
    Reduce build noise by fixing compiler warnings.
    
    ### Modifications
    
    Fixed various compiler warnings in the pulsar-client-*shade-test modules.
---
 .../apache/pulsar/tests/integration/SimpleProducerConsumerTest.java | 6 +++---
 .../apache/pulsar/tests/integration/SimpleProducerConsumerTest.java | 6 +++---
 .../apache/pulsar/tests/integration/SimpleProducerConsumerTest.java | 4 ++--
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/tests/pulsar-client-admin-shade-test/src/test/java/org/apache/pulsar/tests/integration/SimpleProducerConsumerTest.java b/tests/pulsar-client-admin-shade-test/src/test/java/org/apache/pulsar/tests/integration/SimpleProducerConsumerTest.java
index 9d00f5e7c8a..3e33cd13a47 100644
--- a/tests/pulsar-client-admin-shade-test/src/test/java/org/apache/pulsar/tests/integration/SimpleProducerConsumerTest.java
+++ b/tests/pulsar-client-admin-shade-test/src/test/java/org/apache/pulsar/tests/integration/SimpleProducerConsumerTest.java
@@ -317,14 +317,14 @@ public class SimpleProducerConsumerTest extends TestRetrySupport {
 
         int numberOfMessages = 100;
         String message = "my-message";
-        Set<String> messages = new HashSet(); // Since messages are in random order
+        Set<String> messages = new HashSet<>(); // Since messages are in random order
         for (int i = 0; i < numberOfMessages; i++) {
             producer.send((message + i).getBytes());
         }
 
         // Consuming from consumer 2 and 3
         // no message should be returned since they can't decrypt the message
-        Message m = consumer2.receive(3, TimeUnit.SECONDS);
+        Message<byte[]> m = consumer2.receive(3, TimeUnit.SECONDS);
         assertNull(m);
         m = consumer3.receive(3, TimeUnit.SECONDS);
         assertNull(m);
@@ -567,7 +567,7 @@ public class SimpleProducerConsumerTest extends TestRetrySupport {
 
         ByteBuffer payloadBuf = ByteBuffer.wrap(msg.getData());
         // try to decrypt use default MessageCryptoBc
-        MessageCrypto crypto = new MessageCryptoBc("test", false);
+        MessageCryptoBc crypto = new MessageCryptoBc("test", false);
         MessageMetadata msgMetadata = new MessageMetadata()
                 .setEncryptionParam(encrParam)
                 .setProducerName("test")
diff --git a/tests/pulsar-client-all-shade-test/src/test/java/org/apache/pulsar/tests/integration/SimpleProducerConsumerTest.java b/tests/pulsar-client-all-shade-test/src/test/java/org/apache/pulsar/tests/integration/SimpleProducerConsumerTest.java
index 982ed51d04b..d66502f6c92 100644
--- a/tests/pulsar-client-all-shade-test/src/test/java/org/apache/pulsar/tests/integration/SimpleProducerConsumerTest.java
+++ b/tests/pulsar-client-all-shade-test/src/test/java/org/apache/pulsar/tests/integration/SimpleProducerConsumerTest.java
@@ -320,14 +320,14 @@ public class SimpleProducerConsumerTest extends TestRetrySupport {
 
         int numberOfMessages = 100;
         String message = "my-message";
-        Set<String> messages = new HashSet(); // Since messages are in random order
+        Set<String> messages = new HashSet<>(); // Since messages are in random order
         for (int i = 0; i < numberOfMessages; i++) {
             producer.send((message + i).getBytes());
         }
 
         // Consuming from consumer 2 and 3
         // no message should be returned since they can't decrypt the message
-        Message m = consumer2.receive(3, TimeUnit.SECONDS);
+        Message<byte[]> m = consumer2.receive(3, TimeUnit.SECONDS);
         assertNull(m);
         m = consumer3.receive(3, TimeUnit.SECONDS);
         assertNull(m);
@@ -567,7 +567,7 @@ public class SimpleProducerConsumerTest extends TestRetrySupport {
 
         ByteBuffer payloadBuf = ByteBuffer.wrap(msg.getData());
         // try to decrypt use default MessageCryptoBc
-        MessageCrypto crypto = new MessageCryptoBc("test", false);
+        MessageCryptoBc crypto = new MessageCryptoBc("test", false);
         MessageMetadata msgMetadata = new MessageMetadata()
                 .setEncryptionParam(encrParam)
                 .setProducerName("test")
diff --git a/tests/pulsar-client-shade-test/src/test/java/org/apache/pulsar/tests/integration/SimpleProducerConsumerTest.java b/tests/pulsar-client-shade-test/src/test/java/org/apache/pulsar/tests/integration/SimpleProducerConsumerTest.java
index da6cdde7302..9f6f23595c1 100644
--- a/tests/pulsar-client-shade-test/src/test/java/org/apache/pulsar/tests/integration/SimpleProducerConsumerTest.java
+++ b/tests/pulsar-client-shade-test/src/test/java/org/apache/pulsar/tests/integration/SimpleProducerConsumerTest.java
@@ -324,7 +324,7 @@ public class SimpleProducerConsumerTest extends TestRetrySupport {
 
         // Consuming from consumer 2 and 3
         // no message should be returned since they can't decrypt the message
-        Message m = consumer2.receive(3, TimeUnit.SECONDS);
+        Message<byte[]> m = consumer2.receive(3, TimeUnit.SECONDS);
         assertNull(m);
         m = consumer3.receive(3, TimeUnit.SECONDS);
         assertNull(m);
@@ -564,7 +564,7 @@ public class SimpleProducerConsumerTest extends TestRetrySupport {
 
         ByteBuffer payloadBuf = ByteBuffer.wrap(msg.getData());
         // try to decrypt use default MessageCryptoBc
-        MessageCrypto crypto = new MessageCryptoBc("test", false);
+        MessageCryptoBc crypto = new MessageCryptoBc("test", false);
         MessageMetadata msgMetadata = new MessageMetadata()
                 .setEncryptionParam(encrParam)
                 .setProducerName("test")