svn commit: r1152540 - in /trafficserver/traffic/trunk/mgmt: cluster/ClusterCom.cc preparse/StoreReadConfig.cc utils/WebMgmtUtils.cc web2/WebOverview.cc

[bc...@apache.org]

Author: bcall
Date: Sun Jul 31 03:44:05 2011
New Revision: 1152540

URL: http://svn.apache.org/viewvc?rev=1152540&view=rev
Log:
TS-898 "fixed" problems reported by Coverity
1. Changed sprintf to snprintf
2. ignore error on sscanf that is safe

Modified:
    trafficserver/traffic/trunk/mgmt/cluster/ClusterCom.cc
    trafficserver/traffic/trunk/mgmt/preparse/StoreReadConfig.cc
    trafficserver/traffic/trunk/mgmt/utils/WebMgmtUtils.cc
    trafficserver/traffic/trunk/mgmt/web2/WebOverview.cc

Modified: trafficserver/traffic/trunk/mgmt/cluster/ClusterCom.cc
URL: http://svn.apache.org/viewvc/trafficserver/traffic/trunk/mgmt/cluster/ClusterCom.cc?rev=1152540&r1=1152539&r2=1152540&view=diff
==============================================================================
--- trafficserver/traffic/trunk/mgmt/cluster/ClusterCom.cc (original)
+++ trafficserver/traffic/trunk/mgmt/cluster/ClusterCom.cc Sun Jul 31 03:44:05 2011
@@ -1428,12 +1428,12 @@ ClusterCom::constructSharedGenericPacket
     if (rec->rec_type == RECT_NODE) {
       switch (rec->data_type) {
       case RECD_COUNTER:
-        sprintf(tmp, "%d:%d: %" PRId64 "\n", cnt, rec->data_type, rec->data.rec_counter);
+        snprintf(tmp, sizeof(tmp), "%d:%d: %" PRId64 "\n", cnt, rec->data_type, rec->data.rec_counter);
         ink_strncpy(&message[running_sum], tmp, (max - running_sum));
         running_sum += strlen(tmp);
         break;
       case RECD_INT:
-        sprintf(tmp, "%d:%d: %" PRId64 "\n", cnt, rec->data_type, rec->data.rec_int);
+        snprintf(tmp, sizeof(tmp), "%d:%d: %" PRId64 "\n", cnt, rec->data_type, rec->data.rec_int);
         ink_strncpy(&message[running_sum], tmp, (max - running_sum));
         running_sum += strlen(tmp);
         break;

Modified: trafficserver/traffic/trunk/mgmt/preparse/StoreReadConfig.cc
URL: http://svn.apache.org/viewvc/trafficserver/traffic/trunk/mgmt/preparse/StoreReadConfig.cc?rev=1152540&r1=1152539&r2=1152540&view=diff
==============================================================================
--- trafficserver/traffic/trunk/mgmt/preparse/StoreReadConfig.cc (original)
+++ trafficserver/traffic/trunk/mgmt/preparse/StoreReadConfig.cc Sun Jul 31 03:44:05 2011
@@ -57,6 +57,7 @@ parseStorageFile(int fd)
     while (*e && !isdigit(*e))
       e++;
     if (e && *e) {
+      // coverity[secure_coding]
       if (1 != sscanf(e, "%" PRId64 "", &size)) {
         err = "error parsing size";
         goto Lfail;

Modified: trafficserver/traffic/trunk/mgmt/utils/WebMgmtUtils.cc
URL: http://svn.apache.org/viewvc/trafficserver/traffic/trunk/mgmt/utils/WebMgmtUtils.cc?rev=1152540&r1=1152539&r2=1152540&view=diff
==============================================================================
--- trafficserver/traffic/trunk/mgmt/utils/WebMgmtUtils.cc (original)
+++ trafficserver/traffic/trunk/mgmt/utils/WebMgmtUtils.cc Sun Jul 31 03:44:05 2011
@@ -563,7 +563,7 @@ varStrFromName(const char *varNameConst,
     } else if (formatOption == 'c') {
       commaStrFromInt(data.rec_int, bufVal);
     } else {
-      sprintf(bufVal, "%" PRId64 "", data.rec_int);
+      snprintf(bufVal, bufLen, "%" PRId64 "", data.rec_int);
     }
     break;
 
@@ -576,7 +576,7 @@ varStrFromName(const char *varNameConst,
     } else if (formatOption == 'c') {
       commaStrFromInt(data.rec_counter, bufVal);
     } else {
-      sprintf(bufVal, "%" PRId64 "", data.rec_counter);
+      snprintf(bufVal, bufLen, "%" PRId64 "", data.rec_counter);
     }
     break;
   case RECD_FLOAT:

Modified: trafficserver/traffic/trunk/mgmt/web2/WebOverview.cc
URL: http://svn.apache.org/viewvc/trafficserver/traffic/trunk/mgmt/web2/WebOverview.cc?rev=1152540&r1=1152539&r2=1152540&view=diff
==============================================================================
--- trafficserver/traffic/trunk/mgmt/web2/WebOverview.cc (original)
+++ trafficserver/traffic/trunk/mgmt/web2/WebOverview.cc Sun Jul 31 03:44:05 2011
@@ -442,7 +442,7 @@ overviewRecord::varStrFromName(const cha
     } else if (formatOption == 'c') {
       commaStrFromInt(data.int_data, bufVal);
     } else {
-      sprintf(bufVal, "%" PRId64 "", data.int_data);
+      snprintf(bufVal, bufLen, "%" PRId64 "", data.int_data);
     }
     break;
   case RECD_COUNTER:
@@ -454,7 +454,7 @@ overviewRecord::varStrFromName(const cha
     } else if (formatOption == 'c') {
       commaStrFromInt(data.counter_data, bufVal);
     } else {
-      sprintf(bufVal, "%" PRId64 "", data.counter_data);
+      snprintf(bufVal, bufLen, "%" PRId64 "", data.counter_data);
     }
     break;
   case RECD_FLOAT: