You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by he...@apache.org on 2011/09/23 19:24:31 UTC

svn commit: r1174897 - in /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql: Driver.java log/PerfLogger.java

Author: heyongqiang
Date: Fri Sep 23 17:24:31 2011
New Revision: 1174897

URL: http://svn.apache.org/viewvc?rev=1174897&view=rev
Log:
HIVE-2461: Add method to PerfLogger to perform cleanup/final steps. (Kevin Wilfong via He Yongqiang)

Modified:
    hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java
    hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java

Modified: hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java
URL: http://svn.apache.org/viewvc/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java?rev=1174897&r1=1174896&r2=1174897&view=diff
==============================================================================
--- hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java (original)
+++ hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java Fri Sep 23 17:24:31 2011
@@ -952,6 +952,7 @@ public class Driver implements CommandPr
 
     //if needRequireLock is false, the release here will do nothing because there is no lock
     releaseLocks(ctx.getHiveLocks());
+    PerfLogger.getPerfLogger().close(LOG, plan);
     return new CommandProcessorResponse(ret);
   }
 

Modified: hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java
URL: http://svn.apache.org/viewvc/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java?rev=1174897&r1=1174896&r2=1174897&view=diff
==============================================================================
--- hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java (original)
+++ hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java Fri Sep 23 17:24:31 2011
@@ -25,6 +25,7 @@ import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
 import org.apache.hadoop.hive.conf.HiveConf;
 import org.apache.hadoop.hive.conf.HiveConf.ConfVars;
+import org.apache.hadoop.hive.ql.QueryPlan;
 import org.apache.hadoop.hive.ql.session.SessionState;
 import org.apache.hadoop.util.ReflectionUtils;
 
@@ -121,4 +122,13 @@ public class PerfLogger {
 
     return duration;
   }
+
+  /**
+   * Call this function at the end of processing a query (any time after the last call to PerfLogEnd
+   * for a given query) to run any cleanup/final steps that need to be run
+   * @param _log
+   */
+  public void close(Log _log, QueryPlan queryPlan) {
+
+  }
 }