You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/12/03 21:54:37 UTC

[GitHub] [calcite] xndai commented on issue #1543: [CALCITE-3455] Redundant rule firing for both logical and physical nodes

xndai commented on issue #1543: [CALCITE-3455] Redundant rule firing for both logical and physical nodes
URL: https://github.com/apache/calcite/pull/1543#issuecomment-561374301
 
 
   @vlsi @zabetak @rubenada @hsyuan I've updated this patch based on your feedback. Now I create separate LOGICAL_INSTANCE for rules that potentially would only match for logical nodes. Now Calcite users can customize the rule set and use the LOGICAL_INSTANCE if they want. Also updated some unit tests to use the LOGICAL_INSTANCE instead. Please take a look.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services