You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Hari Shreedharan <hs...@cloudera.com> on 2012/07/09 09:28:31 UTC
Review Request: FLUME-1356: Interceptor docs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5830/
-----------------------------------------------------------
Review request for Flume, Arvind Prabhakar and Mike Percy.
Description
-------
Adding interceptor docs
This addresses bug FLUME-1356.
https://issues.apache.org/jira/browse/FLUME-1356
Diffs
-----
flume-ng-doc/sphinx/FlumeUserGuide.rst a53e30d
Diff: https://reviews.apache.org/r/5830/diff/
Testing
-------
Docs only change.
Thanks,
Hari Shreedharan
Re: Review Request: FLUME-1356: Interceptor docs.
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5830/#review8963
-----------------------------------------------------------
Ship it!
Hi Hari,
the documentation seems very good to me. Thank you for your time.I just have one comment to incorrectly specified table that is breaking documentation:
flume-ng-doc/sphinx/FlumeUserGuide.rst
<https://reviews.apache.org/r/5830/#comment19054>
This last line in the table hove more "=" characters in the first column than the first line of the table which produces error message on the generated documentation:
System Message: ERROR/3 (/home/jarcec/projects/apache/flume/trunk/flume-ng-doc/sphinx/FlumeUserGuide.rst, line 739)
Malformed table. Bottom/header table border does not match top border.
- Jarek Cecho
On July 9, 2012, 7:28 a.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5830/
> -----------------------------------------------------------
>
> (Updated July 9, 2012, 7:28 a.m.)
>
>
> Review request for Flume, Arvind Prabhakar and Mike Percy.
>
>
> Description
> -------
>
> Adding interceptor docs
>
>
> This addresses bug FLUME-1356.
> https://issues.apache.org/jira/browse/FLUME-1356
>
>
> Diffs
> -----
>
> flume-ng-doc/sphinx/FlumeUserGuide.rst a53e30d
>
> Diff: https://reviews.apache.org/r/5830/diff/
>
>
> Testing
> -------
>
> Docs only change.
>
>
> Thanks,
>
> Hari Shreedharan
>
>
Re: Review Request: FLUME-1356: Interceptor docs.
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5830/#review8971
-----------------------------------------------------------
Ship it!
Seems fine now, thanks Hari!
- Jarek Cecho
On July 9, 2012, 4:13 p.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5830/
> -----------------------------------------------------------
>
> (Updated July 9, 2012, 4:13 p.m.)
>
>
> Review request for Flume, Arvind Prabhakar and Mike Percy.
>
>
> Description
> -------
>
> Adding interceptor docs
>
>
> This addresses bug FLUME-1356.
> https://issues.apache.org/jira/browse/FLUME-1356
>
>
> Diffs
> -----
>
> flume-ng-doc/sphinx/FlumeUserGuide.rst a53e30d
>
> Diff: https://reviews.apache.org/r/5830/diff/
>
>
> Testing
> -------
>
> Docs only change.
>
>
> Thanks,
>
> Hari Shreedharan
>
>
Re: Review Request: FLUME-1356: Interceptor docs.
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5830/
-----------------------------------------------------------
(Updated July 9, 2012, 4:13 p.m.)
Review request for Flume, Arvind Prabhakar and Mike Percy.
Changes
-------
Removing trailing whitespace.
Description
-------
Adding interceptor docs
This addresses bug FLUME-1356.
https://issues.apache.org/jira/browse/FLUME-1356
Diffs (updated)
-----
flume-ng-doc/sphinx/FlumeUserGuide.rst a53e30d
Diff: https://reviews.apache.org/r/5830/diff/
Testing
-------
Docs only change.
Thanks,
Hari Shreedharan
Re: Review Request: FLUME-1356: Interceptor docs.
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5830/
-----------------------------------------------------------
(Updated July 9, 2012, 4:06 p.m.)
Review request for Flume, Arvind Prabhakar and Mike Percy.
Changes
-------
Fixed issue mentioned by Jarcec.
Description
-------
Adding interceptor docs
This addresses bug FLUME-1356.
https://issues.apache.org/jira/browse/FLUME-1356
Diffs (updated)
-----
flume-ng-doc/sphinx/FlumeUserGuide.rst a53e30d
Diff: https://reviews.apache.org/r/5830/diff/
Testing
-------
Docs only change.
Thanks,
Hari Shreedharan