[GitHub] [storm] agresch commented on a change in pull request #3317: STORM-3682 Upgrade netty client metrics to use V2 API

[GitBox <gi...@apache.org>]

agresch commented on a change in pull request #3317:
URL: https://github.com/apache/storm/pull/3317#discussion_r467264690



##########
File path: storm-client/src/jvm/org/apache/storm/messaging/netty/Client.java
##########
@@ -420,15 +432,15 @@ public void close() {
 
     private void waitForPendingMessagesToBeSent() {
         LOG.info("waiting up to {} ms to send {} pending messages to {}",
-                 PENDING_MESSAGES_FLUSH_TIMEOUT_MS, pendingMessages.get(), dstAddressPrefixedName);
-        long totalPendingMsgs = pendingMessages.get();
+                 PENDING_MESSAGES_FLUSH_TIMEOUT_MS, pendingMessages.getCount(), dstAddressPrefixedName);
+        long totalPendingMsgs = pendingMessages.getCount();
         long startMs = System.currentTimeMillis();
-        while (pendingMessages.get() != 0) {
+        while (pendingMessages.getCount() != 0) {

Review comment:
       sounds reasonable.  Let me know when you finish the rest of the review and I'll update this.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org