[GitHub] [iceberg] yittg commented on pull request #4140: Refactor TableScanContext to avoid noisy updates while adding field

[GitBox <gi...@apache.org>]

yittg commented on pull request #4140:
URL: https://github.com/apache/iceberg/pull/4140#issuecomment-1042448640


   thanks @RussellSpitzer @rdblue .
   I got touched this class in #4115 when I want to add an plan executor. and found the noisy update way. to avoid always thinking like ' let's refactor it NEXT time ' and leading to more and more meaningless updates, I tried to do this right now here.
   
   If it's really rarely updated, it's definitely ok to leave it as the way it is and close this PR.
   
   And given it's a simple change, i didn't open an issue in advance to discuss it. Sorry for that.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org