You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/25 19:51:02 UTC
[GitHub] [flink-statefun-playground] nathantalewis opened a new pull request #17: Fix the Kubernetes example
nathantalewis opened a new pull request #17:
URL: https://github.com/apache/flink-statefun-playground/pull/17
Some minor typos and a mysteriously missing `type:` for `transport:` were preventing the Kubernetes example from working. According to the documentation at https://nightlies.apache.org/flink/flink-statefun-docs-master/docs/modules/http-endpoint/#transport:
> If not specified, by default, Stateful Functions uses OkHttp.
But instead it was throwing: `MissingKeyException: missing key /type`. By explicitly adding the `type:` value, it no longer throws the exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-statefun-playground] igalshilman closed pull request #17: Fix the Kubernetes example
Posted by GitBox <gi...@apache.org>.
igalshilman closed pull request #17:
URL: https://github.com/apache/flink-statefun-playground/pull/17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-statefun-playground] igalshilman commented on a change in pull request #17: Fix the Kubernetes example
Posted by GitBox <gi...@apache.org>.
igalshilman commented on a change in pull request #17:
URL: https://github.com/apache/flink-statefun-playground/pull/17#discussion_r799281747
##########
File path: deployments/k8s/04-statefun/00-module.yaml
##########
@@ -5,11 +5,12 @@ metadata:
name: module-config
data:
module.yaml: |+
- kind: io.statefun.endpoints.v2.http
+ kind: io.statefun.endpoints.v2/http
spec:
functions: example/*
urlPathTemplate: http://functions.statefun.svc.cluster.local:8000/statefun
transport:
+ type: io.statefun.transports.v1/okhttp
Review comment:
cool, thanks for doing is!
If you need any assistance/stumble something let us know on the user mailing list for Apache Flink.
I'd be happy to help out!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-statefun-playground] nathantalewis commented on a change in pull request #17: Fix the Kubernetes example
Posted by GitBox <gi...@apache.org>.
nathantalewis commented on a change in pull request #17:
URL: https://github.com/apache/flink-statefun-playground/pull/17#discussion_r799028134
##########
File path: deployments/k8s/04-statefun/00-module.yaml
##########
@@ -5,11 +5,12 @@ metadata:
name: module-config
data:
module.yaml: |+
- kind: io.statefun.endpoints.v2.http
+ kind: io.statefun.endpoints.v2/http
spec:
functions: example/*
urlPathTemplate: http://functions.statefun.svc.cluster.local:8000/statefun
transport:
+ type: io.statefun.transports.v1/okhttp
Review comment:
Hi @igalshilman!
I'm trying to get the example to work in gke using a gcs connector instead of minio at the moment. Once I get that up and running then I'll be happy to swing back and see if `type` still needs to be specified here in 3.2.0. 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-statefun-playground] igalshilman commented on a change in pull request #17: Fix the Kubernetes example
Posted by GitBox <gi...@apache.org>.
igalshilman commented on a change in pull request #17:
URL: https://github.com/apache/flink-statefun-playground/pull/17#discussion_r799281747
##########
File path: deployments/k8s/04-statefun/00-module.yaml
##########
@@ -5,11 +5,12 @@ metadata:
name: module-config
data:
module.yaml: |+
- kind: io.statefun.endpoints.v2.http
+ kind: io.statefun.endpoints.v2/http
spec:
functions: example/*
urlPathTemplate: http://functions.statefun.svc.cluster.local:8000/statefun
transport:
+ type: io.statefun.transports.v1/okhttp
Review comment:
cool, thanks for doing is!
If you need any assistance/stumble upon something let me know, I'd be happy to help out!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-statefun-playground] nathantalewis commented on a change in pull request #17: Fix the Kubernetes example
Posted by GitBox <gi...@apache.org>.
nathantalewis commented on a change in pull request #17:
URL: https://github.com/apache/flink-statefun-playground/pull/17#discussion_r799861406
##########
File path: deployments/k8s/04-statefun/00-module.yaml
##########
@@ -5,11 +5,12 @@ metadata:
name: module-config
data:
module.yaml: |+
- kind: io.statefun.endpoints.v2.http
+ kind: io.statefun.endpoints.v2/http
spec:
functions: example/*
urlPathTemplate: http://functions.statefun.svc.cluster.local:8000/statefun
transport:
+ type: io.statefun.transports.v1/okhttp
Review comment:
Great news! Everything worked in Statefun 3.2.0 even when `type` wasn't specified. I've pushed a new commit removing that line from this PR. 🥳
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-statefun-playground] igalshilman commented on a change in pull request #17: Fix the Kubernetes example
Posted by GitBox <gi...@apache.org>.
igalshilman commented on a change in pull request #17:
URL: https://github.com/apache/flink-statefun-playground/pull/17#discussion_r798008958
##########
File path: deployments/k8s/04-statefun/00-module.yaml
##########
@@ -5,11 +5,12 @@ metadata:
name: module-config
data:
module.yaml: |+
- kind: io.statefun.endpoints.v2.http
+ kind: io.statefun.endpoints.v2/http
spec:
functions: example/*
urlPathTemplate: http://functions.statefun.svc.cluster.local:8000/statefun
transport:
+ type: io.statefun.transports.v1/okhttp
Review comment:
This shouldn't be needed anymore once 3.2.0 was released, but apparently was the case in 3.1.
If you still have the capacity would you be able to quickly verify that this works for you without specifying the `type`?
##########
File path: deployments/k8s/04-statefun/00-module.yaml
##########
@@ -5,11 +5,12 @@ metadata:
name: module-config
data:
module.yaml: |+
- kind: io.statefun.endpoints.v2.http
+ kind: io.statefun.endpoints.v2/http
Review comment:
oh, good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-statefun-playground] igalshilman commented on a change in pull request #17: Fix the Kubernetes example
Posted by GitBox <gi...@apache.org>.
igalshilman commented on a change in pull request #17:
URL: https://github.com/apache/flink-statefun-playground/pull/17#discussion_r799281747
##########
File path: deployments/k8s/04-statefun/00-module.yaml
##########
@@ -5,11 +5,12 @@ metadata:
name: module-config
data:
module.yaml: |+
- kind: io.statefun.endpoints.v2.http
+ kind: io.statefun.endpoints.v2/http
spec:
functions: example/*
urlPathTemplate: http://functions.statefun.svc.cluster.local:8000/statefun
transport:
+ type: io.statefun.transports.v1/okhttp
Review comment:
cool, thanks for doing is!
If you need any assistance/stumble upon something let us know on the user mailing list for Apache Flink.
I'd be happy to help out!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org