You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by tr...@apache.org on 2018/07/23 22:06:01 UTC
[04/11] flink git commit: [FLINK-9838][logging] Don't log slot
request failures on the ResourceManager
[FLINK-9838][logging] Don't log slot request failures on the ResourceManager
This closes #6373.
Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/4e616a83
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/4e616a83
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/4e616a83
Branch: refs/heads/master
Commit: 4e616a8362744c15a71e0e57ad68fbb52266c837
Parents: 57b3cde
Author: Till Rohrmann <tr...@apache.org>
Authored: Thu Jul 19 13:07:44 2018 +0200
Committer: Till Rohrmann <tr...@apache.org>
Committed: Tue Jul 24 00:05:39 2018 +0200
----------------------------------------------------------------------
.../org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java | 4 ++--
.../apache/flink/runtime/resourcemanager/ResourceManager.java | 1 -
2 files changed, 2 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flink/blob/4e616a83/flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java
----------------------------------------------------------------------
diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java b/flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java
index 27440a3..829c82e 100644
--- a/flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java
+++ b/flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java
@@ -1011,7 +1011,7 @@ public class SlotPool extends RpcEndpoint implements SlotPoolGateway, AllocatedS
failPendingRequest(pendingRequest, cause);
}
else if (availableSlots.tryRemove(allocationID)) {
- log.debug("Failed available slot [{}] with ", allocationID, cause);
+ log.debug("Failed available slot with allocation id {}.", allocationID, cause);
}
else {
AllocatedSlot allocatedSlot = allocatedSlots.remove(allocationID);
@@ -1021,7 +1021,7 @@ public class SlotPool extends RpcEndpoint implements SlotPoolGateway, AllocatedS
allocatedSlot.releasePayload(cause);
}
else {
- log.trace("Outdated request to fail slot [{}] with ", allocationID, cause);
+ log.trace("Outdated request to fail slot with allocation id {}.", allocationID, cause);
}
}
// TODO: add some unit tests when the previous two are ready, the allocation may failed at any phase
http://git-wip-us.apache.org/repos/asf/flink/blob/4e616a83/flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
----------------------------------------------------------------------
diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java b/flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
index 453ec8b..a992632 100644
--- a/flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
+++ b/flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
@@ -1005,7 +1005,6 @@ public abstract class ResourceManager<WorkerType extends ResourceIDRetrievable>
@Override
public void notifyAllocationFailure(JobID jobId, AllocationID allocationId, Exception cause) {
validateRunsInMainThread();
- log.info("Slot request with allocation id {} for job {} failed.", allocationId, jobId, cause);
JobManagerRegistration jobManagerRegistration = jobManagerRegistrations.get(jobId);
if (jobManagerRegistration != null) {