[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #7358: limit tables/views returned if schema is not provided

[GitBox <gi...@apache.org>]

betodealmeida commented on a change in pull request #7358: limit tables/views returned if schema is not provided
URL: https://github.com/apache/incubator-superset/pull/7358#discussion_r277849012
 
 

 ##########
 File path: superset/views/core.py
 ##########
 @@ -1513,6 +1513,25 @@ def tables(self, db_id, schema, substr, force_refresh='false'):
             table_names = [tn for tn in table_names if substr in tn]
             view_names = [vn for vn in view_names if substr in vn]
 
+        if not schema and database.default_schemas:
 
 Review comment:
   Nice, I like this because if the parameter is not there it doesn't affect the current behavior, so people can opt-in into this feature.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org