You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2019/08/25 09:20:10 UTC

Review Request 71368: Updated site's middleman versions.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71368/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Repository: mesos


Description
-------

Updated site's middleman versions.


Diffs
-----

  site/Gemfile c4920309ce38d4601433674a1c13b3d220b865d5 
  site/Gemfile.lock 343d3e64b0fdb0130392c1f8383b5057ad2ce470 


Diff: https://reviews.apache.org/r/71368/diff/1/


Testing
-------

Site still generates.


Thanks,

Benjamin Bannier

Re: Review Request 71368: Updated site's middleman versions.

Posted by Benjamin Bannier <bb...@apache.org>.


> On Aug. 25, 2019, 11:09 p.m., Benjamin Mahler wrote:
> > site/Gemfile
> > Lines 3-6 (original), 3-6 (patched)
> > <https://reviews.apache.org/r/71368/diff/1/?file=2162893#file2162893line3>
> >
> >     Hm.. what's this syntax expressing? Ditto above.

This means "any package version with version 3.x.x", see https://bundler.io/v1.5/gemfile.html#gemfiles.

We additionally version-control `Gemfile.lock`, so there is no strong need to bind specific versions in this case here. We want to exclude middleman from 4.x.x upwards though as it is incompatible.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71368/#review217429
-----------------------------------------------------------


On Aug. 25, 2019, 11:20 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71368/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2019, 11:20 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated site's middleman versions.
> 
> 
> Diffs
> -----
> 
>   site/Gemfile c4920309ce38d4601433674a1c13b3d220b865d5 
>   site/Gemfile.lock 343d3e64b0fdb0130392c1f8383b5057ad2ce470 
> 
> 
> Diff: https://reviews.apache.org/r/71368/diff/1/
> 
> 
> Testing
> -------
> 
> Site still generates.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 71368: Updated site's middleman versions.

Posted by Benjamin Mahler <bm...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71368/#review217429
-----------------------------------------------------------




site/Gemfile
Lines 3-6 (original), 3-6 (patched)
<https://reviews.apache.org/r/71368/#comment304705>

    Hm.. what's this syntax expressing? Ditto above.


- Benjamin Mahler


On Aug. 25, 2019, 9:20 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71368/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2019, 9:20 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated site's middleman versions.
> 
> 
> Diffs
> -----
> 
>   site/Gemfile c4920309ce38d4601433674a1c13b3d220b865d5 
>   site/Gemfile.lock 343d3e64b0fdb0130392c1f8383b5057ad2ce470 
> 
> 
> Diff: https://reviews.apache.org/r/71368/diff/1/
> 
> 
> Testing
> -------
> 
> Site still generates.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 71368: Updated site's middleman versions.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71368/#review217427
-----------------------------------------------------------



Patch looks great!

Reviews applied: [71367, 71368]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Aug. 25, 2019, 9:20 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71368/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2019, 9:20 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated site's middleman versions.
> 
> 
> Diffs
> -----
> 
>   site/Gemfile c4920309ce38d4601433674a1c13b3d220b865d5 
>   site/Gemfile.lock 343d3e64b0fdb0130392c1f8383b5057ad2ce470 
> 
> 
> Diff: https://reviews.apache.org/r/71368/diff/1/
> 
> 
> Testing
> -------
> 
> Site still generates.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 71368: Updated site's middleman versions.

Posted by Benjamin Mahler <bm...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71368/#review217435
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Mahler


On Aug. 25, 2019, 9:20 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71368/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2019, 9:20 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated site's middleman versions.
> 
> 
> Diffs
> -----
> 
>   site/Gemfile c4920309ce38d4601433674a1c13b3d220b865d5 
>   site/Gemfile.lock 343d3e64b0fdb0130392c1f8383b5057ad2ce470 
> 
> 
> Diff: https://reviews.apache.org/r/71368/diff/1/
> 
> 
> Testing
> -------
> 
> Site still generates.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>