You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zookeeper.apache.org by GitBox <gi...@apache.org> on 2019/01/31 22:48:23 UTC

[GitHub] eolivelli commented on a change in pull request #795: ZOOKEEPER-3265: Fix fileset to match shell scripts and python files i…

eolivelli commented on a change in pull request #795: ZOOKEEPER-3265: Fix fileset to match shell scripts and python files i…
URL: https://github.com/apache/zookeeper/pull/795#discussion_r252872485
 
 

 ##########
 File path: build.xml
 ##########
 @@ -973,8 +973,9 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle">
       <chmod perm="ugo+x" type="file" parallel="false">
         <fileset dir="${dist.dir}/bin"/>
         <fileset dir="${dist.dir}/sbin"/>
-        <fileset dir="${dist.dir}/src/zookeeper-contrib/">
-          <include name="*/bin/*" />
+        <fileset dir="${dist.dir}/contrib/">
+          <include name="**/*.sh" />
+          <include name="**/*.py" />
 
 Review comment:
   Why not keeping 'bin' explicitly?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services